Date: Sun, 27 Dec 2015 10:10:37 -0700 From: Ian Lepore <ian@freebsd.org> To: Dmitry Chagin <dchagin@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r292777 - in head: lib/libc/sys sys/kern Message-ID: <1451236237.1369.9.camel@freebsd.org> In-Reply-To: <201512271537.tBRFb7nN095297@repo.freebsd.org> References: <201512271537.tBRFb7nN095297@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sun, 2015-12-27 at 15:37 +0000, Dmitry Chagin wrote: > Author: dchagin > Date: Sun Dec 27 15:37:07 2015 > New Revision: 292777 > URL: https://svnweb.freebsd.org/changeset/base/292777 > > Log: > Verify that tv_sec value specified in settimeofday() and > clock_settime() > (CLOCK_REALTIME case) system calls is non negative. > This commit hides a kernel panic in atrtc_settime() as the > clock_ts_to_ct() > does not properly convert negative tv_sec. > > ps. in my opinion clock_ts_to_ct() should be rewritten to properly > handle > negative tv_sec values. > > Differential Revision: https://reviews.freebsd.org/D4714 > Reviewed by: kib > > MFC after: 1 week IMO, this change is completely unacceptable. If there is a bug in atrtc code, then by all means fix it, but preventing anyone from setting valid time values on the system because one driver's code can't handle it is just wrong. -- Ian
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1451236237.1369.9.camel>