Date: Mon, 6 Oct 2014 07:35:37 +0400 From: Andrej Zverev <az@freebsd.org> To: Bartek Rutkowski <robak@freebsd.org> Cc: "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org> Subject: Re: svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl Message-ID: <CAD5bB%2Bg5oUuWUXLpJia7vssd0SjTwn%2B0geRZApPULtQn%2B_gDxQ@mail.gmail.com> In-Reply-To: <201410052140.s95LeUa9030114@svn.freebsd.org> References: <201410052140.s95LeUa9030114@svn.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
Only few questions :-)
1. {LOCALBASE}/libexec/nagios/utils.pm:${PORTSDIR}/net-mgmt/nagios-plugins
<- why don't use pkgname instead?
2. @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL}," ${WRKSRC}/${PORTNAME} <-
you can use USES=shebangfix
P.S. Approved by: mentors (implicit) <- not sure about this they both
did it, or only one of them and why don't write who they are?
On Mon, Oct 6, 2014 at 1:40 AM, Bartek Rutkowski <robak@freebsd.org> wrote:
> Author: robak
> Date: Sun Oct 5 21:40:29 2014
> New Revision: 370131
> URL: https://svnweb.freebsd.org/changeset/ports/370131
> QAT: https://qat.redports.org/buildarchive/r370131/
>
> Log:
> net-mgmt/nagios-check_dhcp.pl: NEW PORT - Nagios DHCP check plugin
>
> This plugin tests the availability of a given DHCP server using unicast
> delivery.
>
> PR: 187623
> Submitted by: Lawrence Chen <beastie@tardisi.com>
> Approved by: mentors (implicit)
>
> Added:
> head/net-mgmt/nagios-check_dhcp.pl/
> head/net-mgmt/nagios-check_dhcp.pl/Makefile (contents, props changed)
> head/net-mgmt/nagios-check_dhcp.pl/distinfo (contents, props changed)
> head/net-mgmt/nagios-check_dhcp.pl/pkg-descr (contents, props changed)
> Modified:
> head/net-mgmt/Makefile
>
> Modified: head/net-mgmt/Makefile
>
> ==============================================================================
> --- head/net-mgmt/Makefile Sun Oct 5 21:36:02 2014 (r370130)
> +++ head/net-mgmt/Makefile Sun Oct 5 21:40:29 2014 (r370131)
> @@ -108,6 +108,7 @@
> SUBDIR += nagios-check_bacula5
> SUBDIR += nagios-check_clamav
> SUBDIR += nagios-check_cpu_usage
> + SUBDIR += nagios-check_dhcp.pl
> SUBDIR += nagios-check_email_delivery
> SUBDIR += nagios-check_hdd_health
> SUBDIR += nagios-check_hp_bladechassis
>
> Added: head/net-mgmt/nagios-check_dhcp.pl/Makefile
>
> ==============================================================================
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ head/net-mgmt/nagios-check_dhcp.pl/Makefile Sun Oct 5 21:40:29 2014
> (r370131)
> @@ -0,0 +1,37 @@
> +# Created by: Lawrence Chen <beastie@tardisi.com>
> +# $FreeBSD$
> +
> +PORTNAME= check_dhcp.pl
> +PORTVERSION= 0.1
> +CATEGORIES= net-mgmt
> +MASTER_SITES=
> http://exchange.nagios.org/components/com_mtree/attachment.php?link_id=1526&cf_id=24&dummy=/
> +PKGNAMEPREFIX= nagios-
> +DISTNAME= ${PORTNAME}
> +EXTRACT_SUFX=
> +
> +MAINTAINER= beastie@tardisi.com
> +COMMENT= Check the availability of a DHCP server using unicast
> delivery
> +
> +RUN_DEPENDS= ${LOCALBASE}/libexec/nagios/utils.pm:${PORTSDIR}/net-mgmt/nagios-plugins
> \
> + p5-IO-Interface>=0:${PORTSDIR}/net/p5-IO-Interface \
> + p5-Net-DHCP-Watch>=0:${PORTSDIR}/net/p5-Net-DHCP-Watch
> +
> +USES= perl5
> +USE_PERL5= run
> +
> +PLIST_FILES= libexec/nagios/check_dhcp.pl
> +NO_BUILD= yes
> +NO_WRKSUBDIR= yes
> +
> +post-patch:
> + @${REINPLACE_CMD} -e "s,/usr/bin/perl,${PERL},"
> ${WRKSRC}/${PORTNAME}
> +
> +do-extract:
> + @${MKDIR} ${WRKDIR}
> + @${CP} ${DISTDIR}/${PORTNAME} ${WRKDIR}/
> +
> +do-install:
> + ${MKDIR} ${STAGEDIR}${PREFIX}/libexec/nagios
> + ${INSTALL_SCRIPT} ${WRKSRC}/check_dhcp.pl
> ${STAGEDIR}${PREFIX}/libexec/nagios/check_dhcp.pl
> +
> +.include <bsd.port.mk>
>
> Added: head/net-mgmt/nagios-check_dhcp.pl/distinfo
>
> ==============================================================================
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ head/net-mgmt/nagios-check_dhcp.pl/distinfo Sun Oct 5 21:40:29 2014
> (r370131)
> @@ -0,0 +1,2 @@
> +SHA256 (check_dhcp.pl) =
> 7aa6f26ae11f66e7b7a0100649a42fbd7179279a1bc2ff0305d633be59bcc87b
> +SIZE (check_dhcp.pl) = 4171
>
> Added: head/net-mgmt/nagios-check_dhcp.pl/pkg-descr
>
> ==============================================================================
> --- /dev/null 00:00:00 1970 (empty, because file is newly added)
> +++ head/net-mgmt/nagios-check_dhcp.pl/pkg-descr Sun Oct 5
> 21:40:29 2014 (r370131)
> @@ -0,0 +1,4 @@
> +This plugin tests the availability of a given DHCP server using unicast
> +delivery.
> +
> +WWW: http://exchange.nagios.org/
>
>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAD5bB%2Bg5oUuWUXLpJia7vssd0SjTwn%2B0geRZApPULtQn%2B_gDxQ>