Skip site navigation (1)Skip section navigation (2)
Date:      Fri, 12 Mar 2021 23:07:28 +0100 (CET)
From:      Gerald Pfeifer <gerald@pfeifer.com>
To:        Piotr Kubaj <pkubaj@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org,  svn-ports-head@freebsd.org
Subject:   Re: svn commit: r568012 - head/net/tightvnc
Message-ID:  <13e0fa6a-7ea4-d321-c75e-474eeb415ee9@pfeifer.com>
In-Reply-To: <202103101603.12AG371X067963@repo.freebsd.org>
References:  <202103101603.12AG371X067963@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, 10 Mar 2021, Piotr Kubaj wrote:
> Author: pkubaj Date: Wed Mar 10 16:03:06 2021 New Revision: 568012 URL: 
> https://svnweb.freebsd.org/changeset/ports/568012
> 
> Log:
>   net/tightvnc: fix build on powerpc64* and probably also on aarch64 and riscv64
>   
>   Clang can't build this, use GCC:
>   In file included from ./cfbmskbits.h:39:
>   ../hw/xfree86/common/compiler.h:437:8: error: invalid output constraint '=a' in asm
>          "=a" (ret) :


> +.if ${ARCH} == aarch64 || ${ARCH:Mpowerpc64*} || ${ARCH} == riscv64
> +USE_GCC=	any
> +.endif

Do you intentionally focus on USE_GCC=any?  On riscv64 this is always
equivalent to USE_GCC=yes, and even on powerpc - do we want to use the
the age old GCC 4.2 in base *and*, more importantly, use different
compilers on 11.x and 13.x?

USE_GCC=yes avoids all of this and provides more consistency and fewer
test escapes.

Gerald



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?13e0fa6a-7ea4-d321-c75e-474eeb415ee9>