Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 21 Aug 2019 23:13:00 +0000 (UTC)
From:      Mark Johnston <markj@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   svn commit: r351359 - head/cddl/contrib/opensolaris/cmd/lockstat
Message-ID:  <201908212313.x7LND0OP040236@repo.freebsd.org>

next in thread | raw e-mail | index | archive | help
Author: markj
Date: Wed Aug 21 23:13:00 2019
New Revision: 351359
URL: https://svnweb.freebsd.org/changeset/base/351359

Log:
  Fix inverted predicates for sx lock hold events in lockstat(1).
  
  This caused shared sx holds to be reported as exclusive, and vice
  versa.
  
  Reviewed by:	mjg
  MFC after:	3 days
  Sponsored by:	The FreeBSD Foundation

Modified:
  head/cddl/contrib/opensolaris/cmd/lockstat/lockstat.c

Modified: head/cddl/contrib/opensolaris/cmd/lockstat/lockstat.c
==============================================================================
--- head/cddl/contrib/opensolaris/cmd/lockstat/lockstat.c	Wed Aug 21 22:42:08 2019	(r351358)
+++ head/cddl/contrib/opensolaris/cmd/lockstat/lockstat.c	Wed Aug 21 23:13:00 2019	(r351359)
@@ -206,10 +206,10 @@ static ls_event_info_t g_event_info[LS_MAX_EVENTS] = {
 	    "lockstat:::rw-release", "arg1 == 1",
 	    "lockstat:::rw-acquire" },
 	{ 'H',	"Lock",	"SX shared hold",			"nsec",
-	    "lockstat:::sx-release", "arg1 == 0",
+	    "lockstat:::sx-release", "arg1 == 1",
 	    "lockstat:::sx-acquire" },
 	{ 'H',	"Lock",	"SX exclusive hold",			"nsec",
-	    "lockstat:::sx-release", "arg1 == 1",
+	    "lockstat:::sx-release", "arg1 == 0",
 	    "lockstat:::sx-acquire" },
 	{ 'H',	"Lock",	"Unknown event (type 38)",		"units"	},
 	{ 'H',	"Lock",	"Unknown event (type 39)",		"units"	},



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201908212313.x7LND0OP040236>