Skip site navigation (1)Skip section navigation (2) 
Date:      Wed, 29 May 2019 18:23:18 +0000 (UTC)
From:      Dimitry Andric <dim@FreeBSD.org>
To:        src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-stable@freebsd.org, svn-src-stable-12@freebsd.org
Subject:   svn commit: r348367 - stable/12/contrib/llvm/lib/CodeGen/SelectionDAG
Message-ID:  <201905291823.x4TINIJ6061398@repo.freebsd.org>
next in thread | raw e-mail | index | archive | help 
Author: dim
Date: Wed May 29 18:23:18 2019
New Revision: 348367
URL: https://svnweb.freebsd.org/changeset/base/348367

Log:
  MFC r348288:
  
  Pull in r361696 from upstream llvm trunk (by Sanjay Patel):
  
    [SelectionDAG] soften assertion when legalizing narrow vector FP ops
  
    The test based on PR42010:
    https://bugs.llvm.org/show_bug.cgi?id=42010
  
    ...may show an inaccuracy for PPC's target defs, but we should not be
    so aggressive with an assert here. There's no telling what
    out-of-tree targets look like.
  
  This fixes an assertion when building the graphics/mesa-dri port for
  PowerPC64.
  
  Reported by:	Mark Millard <marklmi26-fbsd@yahoo.com>
  PR:		238082

Modified:
  stable/12/contrib/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
Directory Properties:
  stable/12/   (props changed)

Modified: stable/12/contrib/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp
==============================================================================
--- stable/12/contrib/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp	Wed May 29 18:11:17 2019	(r348366)
+++ stable/12/contrib/llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp	Wed May 29 18:23:18 2019	(r348367)
@@ -2523,13 +2523,11 @@ void DAGTypeLegalizer::WidenVectorResult(SDNode *N, un
     // We're going to widen this vector op to a legal type by padding with undef
     // elements. If the wide vector op is eventually going to be expanded to
     // scalar libcalls, then unroll into scalar ops now to avoid unnecessary
-    // libcalls on the undef elements. We are assuming that if the scalar op
-    // requires expanding, then the vector op needs expanding too.
+    // libcalls on the undef elements.
     EVT VT = N->getValueType(0);
-    if (TLI.isOperationExpand(N->getOpcode(), VT.getScalarType())) {
-      EVT WideVecVT = TLI.getTypeToTransformTo(*DAG.getContext(), VT);
-      assert(!TLI.isOperationLegalOrCustom(N->getOpcode(), WideVecVT) &&
-             "Target supports vector op, but scalar requires expansion?");
+    EVT WideVecVT = TLI.getTypeToTransformTo(*DAG.getContext(), VT);
+    if (!TLI.isOperationLegalOrCustom(N->getOpcode(), WideVecVT) &&
+        TLI.isOperationExpand(N->getOpcode(), VT.getScalarType())) {
       Res = DAG.UnrollVectorOp(N, WideVecVT.getVectorNumElements());
       break;
     }

Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201905291823.x4TINIJ6061398>