Date: Wed, 22 Feb 2006 19:20:07 GMT From: Nate Nielsen <nielsen@memberwebs.com> To: freebsd-bugs@FreeBSD.org Subject: Re: kern/93720: Kernel Dump to USB umass device Message-ID: <200602221920.k1MJK7C8040980@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
The following reply was made to PR kern/93720; it has been noted by GNATS.
From: Nate Nielsen <nielsen@memberwebs.com>
To: FreeBSD-gnats-submit@FreeBSD.org, freebsd-bugs@FreeBSD.org
Cc:
Subject: Re: kern/93720: Kernel Dump to USB umass device
Date: Wed, 22 Feb 2006 19:22:20 +0000 (GMT)
This is a multi-part message in MIME format.
--------------030305000202070609050606
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Patch which fixes the problem.
--------------030305000202070609050606
Content-Type: text/x-patch;
name="umass-ohci-dump.patch"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline;
filename="umass-ohci-dump.patch"
Index: sys/dev/usb/umass.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/umass.c,v
retrieving revision 1.122.2.6
diff -U3 -r1.122.2.6 umass.c
--- sys/dev/usb/umass.c 29 Jan 2006 00:45:11 -0000 1.122.2.6
+++ sys/dev/usb/umass.c 22 Feb 2006 03:04:02 -0000
@@ -2643,21 +2643,17 @@
}
}
-/* umass_cam_poll
- * all requests are handled through umass_cam_action, requests
- * are never pending. So, nothing to do here.
- */
Static void
umass_cam_poll(struct cam_sim *sim)
{
-#ifdef USB_DEBUG
struct umass_softc *sc = (struct umass_softc *) sim->softc;
DPRINTF(UDMASS_SCSI, ("%s: CAM poll\n",
USBDEVNAME(sc->sc_dev)));
-#endif
- /* nop */
+ usbd_set_polling(sc->sc_udev, 1);
+ usbd_dopoll(sc->iface);
+ usbd_set_polling(sc->sc_udev, 0);
}
Index: sys/dev/usb/ohci.c
===================================================================
RCS file: /home/ncvs/src/sys/dev/usb/ohci.c,v
retrieving revision 1.154.2.2
diff -U3 -r1.154.2.2 ohci.c
--- sys/dev/usb/ohci.c 29 Jan 2006 01:26:46 -0000 1.154.2.2
+++ sys/dev/usb/ohci.c 22 Feb 2006 03:04:05 -0000
@@ -3049,6 +3049,9 @@
splx(s);
+ if (sc->sc_bus.use_polling)
+ ohci_waitintr(sc, xfer);
+
return (USBD_IN_PROGRESS);
}
--------------030305000202070609050606--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200602221920.k1MJK7C8040980>