Date: Sat, 5 Sep 1998 14:55:01 +0100 (BST) From: Doug Rabson <dfr@nlsystems.com> To: "Andrey A. Chernov" <ache@nagual.pp.ru> Cc: John Birrell <jb@freebsd.org>, cvs-committers@freebsd.org, cvs-all@freebsd.org Subject: Re: cvs commit: src/lib/libc/gen sleep.c Message-ID: <Pine.BSF.4.01.9809051454130.360-100000@herring.nlsystems.com> In-Reply-To: <19980905163746.A21849@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
On Sat, 5 Sep 1998, Andrey A. Chernov wrote: > On Sat, Sep 05, 1998 at 01:01:27AM -0700, John Birrell wrote: > > jb 1998/09/05 01:01:27 PDT > > > > Modified files: > > lib/libc/gen sleep.c > > Log: > > Use INT_MAX instead of LONG_MAX since the variable being compared > > is an int, not a long. > > > Please back it out, the test covers the case when > sizeof(unsigned) == sizeof(long) and prevents to overflow signed long with > unsigned value. Something needs to change here. LONG_MAX is too big to compare against an int and generates a warning on the alpha. Maybe compare against UINT_MAX? -- Doug Rabson Mail: dfr@nlsystems.com Nonlinear Systems Ltd. Phone: +44 181 951 1891 Fax: +44 181 381 1039
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?Pine.BSF.4.01.9809051454130.360-100000>