Date: Wed, 15 Jul 2009 12:49:35 +0200 From: Roman Divacky <rdivacky@freebsd.org> To: current@freebsd.org Subject: ppc(4) locking of isa_dma* Message-ID: <20090715104934.GA58659@freebsd.org>
next in thread | raw e-mail | index | archive | help
--5mCyUwZo2JvN/JJP Content-Type: text/plain; charset=us-ascii Content-Disposition: inline hi the isa_dma* functions seem to require Giant. ppc(4) uses those but does not seem to lock Giant or anything. is this ok? is it a bug? I looked at the i386/isa/isa_dma.c and it seems pretty selfcontained (ie. it operates on hw and it's own variables). would it be sufficient to just introduce a new lock and lock with it all the isa_dma* functions ? or is there some indirect dependency on Giant that I cant see? there are not many users of this (most prominently fdc/ppc/sound-isa and some minor stuff). can someone comment? thnx! roman --5mCyUwZo2JvN/JJP Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.12 (FreeBSD) iEYEARECAAYFAkpdtD4ACgkQLVEj6D3CBEwQgQCeI6iXRj+OFKRw8iQcIZNJcCJo dycAn16P40eg46Y/ZxJT2YOQONuyAjPe =fKKJ -----END PGP SIGNATURE----- --5mCyUwZo2JvN/JJP--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090715104934.GA58659>