Date: Tue, 7 Apr 2015 17:16:04 +0200 From: Michael Tuexen <tuexen@fh-muenster.de> To: "Bjoern A. Zeeb" <bz@FreeBSD.org> Cc: svn-src-head@freebsd.org, Takanori Watanabe <takawata@FreeBSD.org>, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r281198 - in head/sys/netgraph/bluetooth: hci include l2cap socket Message-ID: <ACEB0158-A425-4BBF-9931-1598980977EB@fh-muenster.de> In-Reply-To: <B534AEA3-6D44-4CAC-A6C5-2010D7978741@FreeBSD.org> References: <201504071022.t37AMvts041485@svn.freebsd.org> <B534AEA3-6D44-4CAC-A6C5-2010D7978741@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
> On 07 Apr 2015, at 13:36, Bjoern A. Zeeb <bz@FreeBSD.org> wrote: >=20 >=20 >> On 07 Apr 2015, at 10:22 , Takanori Watanabe <takawata@FreeBSD.org> = wrote: >>=20 >> Author: takawata >> Date: Tue Apr 7 10:22:56 2015 >> New Revision: 281198 >> URL: https://svnweb.freebsd.org/changeset/base/281198 >>=20 >> Log: >> Initial Bluetooth LE support. >>=20 >> Note that sockaddr_l2cap structure is changed , check socket address >> to initialize new structure member and define L2CAP_SOCKET_CHECKED >> before including ng_btsocket.h >>=20 >> Differential Revision: https://reviews.freebsd.org/D2021 >> Reviewed by:emax >>=20 >=20 >=20 > I see a lot of: >=20 > = /scratch/tmp/bz/head.svn/lib/libbluetooth/../../sys/netgraph/bluetooth/inc= lude/ng_btsocket.h:246:2: error: #warning "Make sure new member of = socket address initialized" I also do see at least two instances of it breaking the compilation: --- all_subdir_libbluetooth --- --- bluetooth.So --- In file included from = /usr/home/tuexen/head/lib/libbluetooth/bluetooth.c:34: In file included from = /usr/home/tuexen/head/lib/libbluetooth/bluetooth.h:49: = /usr/home/tuexen/head/lib/libbluetooth/../../sys/netgraph/bluetooth/includ= e/ng_btsocket.h:246:2: error: "Make sure new member of socket address = initialized" [-Werror,-W#warnings] #warning "Make sure new member of socket address initialized" ^ 1 error generated. --- dev.So --- In file included from /usr/home/tuexen/head/lib/libbluetooth/dev.c:33: In file included from = /usr/home/tuexen/head/lib/libbluetooth/bluetooth.h:49: = /usr/home/tuexen/head/lib/libbluetooth/../../sys/netgraph/bluetooth/includ= e/ng_btsocket.h:246:2: error: "Make sure new member of socket address = initialized" [-Werror,-W#warnings] #warning "Make sure new member of socket address initialized" ^ 1 error generated. --- bluetooth.So --- *** [bluetooth.So] Error code 1 make[5]: stopped in /usr/home/tuexen/head/lib/libbluetooth Best regards Michael >=20 > when trying to build kernels. Is this expected? >=20 >=20 >> Modified: >> head/sys/netgraph/bluetooth/hci/ng_hci_cmds.c >> head/sys/netgraph/bluetooth/hci/ng_hci_evnt.c >> head/sys/netgraph/bluetooth/hci/ng_hci_main.c >> head/sys/netgraph/bluetooth/hci/ng_hci_misc.c >> head/sys/netgraph/bluetooth/hci/ng_hci_misc.h >> head/sys/netgraph/bluetooth/hci/ng_hci_ulpi.c >> head/sys/netgraph/bluetooth/hci/ng_hci_var.h >> head/sys/netgraph/bluetooth/include/ng_btsocket.h >> head/sys/netgraph/bluetooth/include/ng_btsocket_l2cap.h >> head/sys/netgraph/bluetooth/include/ng_hci.h >> head/sys/netgraph/bluetooth/include/ng_l2cap.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_cmds.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_cmds.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_evnt.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_llpi.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_llpi.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_misc.h >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_ulpi.c >> head/sys/netgraph/bluetooth/l2cap/ng_l2cap_var.h >> head/sys/netgraph/bluetooth/socket/ng_btsocket_hci_raw.c >> head/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap.c >> head/sys/netgraph/bluetooth/socket/ng_btsocket_l2cap_raw.c >=20 > =E2=80=94=20 > Bjoern A. Zeeb Charles Haddon = Spurgeon: > "Friendship is one of the sweetest joys of life. Many might have = failed > beneath the bitterness of their trial had they not found a friend." >=20 >=20 >=20
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?ACEB0158-A425-4BBF-9931-1598980977EB>