Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 9 Jan 2007 11:17:54 -0500
From:      John Baldwin <jhb@freebsd.org>
To:        pyunyh@gmail.com
Cc:        cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon <yongari@freebsd.org>
Subject:   Re: cvs commit: src/sys/dev/msk if_msk.c
Message-ID:  <200701091117.55545.jhb@freebsd.org>
In-Reply-To: <20070109002450.GA24958@cdnetworks.co.kr>
References:  <200701080019.l080Js9g077860@repoman.freebsd.org> <200701081135.59717.jhb@freebsd.org> <20070109002450.GA24958@cdnetworks.co.kr>

next in thread | previous in thread | raw e-mail | index | archive | help
On Monday 08 January 2007 19:24, Pyun YongHyeon wrote:
> On Mon, Jan 08, 2007 at 11:35:59AM -0500, John Baldwin wrote:
>  > On Sunday 07 January 2007 19:19, Pyun YongHyeon wrote:
>  > > yongari     2007-01-08 00:19:53 UTC
>  > > 
>  > >   FreeBSD src repository
>  > > 
>  > >   Modified files:
>  > >     sys/dev/msk          if_msk.c 
>  > >   Log:
>  > >   Initialize legacy SYS_RES_IRQ resources before attempting to use MSI.
>  > >   This fixes legacy SYS_RES_IRQ resource allocation failure when MSI is
>  > >   disabled.
>  > >   
>  > >   Reported by:    rrs
>  > >   Tested by:      rrs
>  > 
>  > Gah, my bad.  I would prefer to set it down before the 'if (msic == 
2...)' so 
>  > all the logic for it is in one place, but anyways, you should remove the 
> 
> At first I thought that too. But mskc_attach() checks chip id and
> then exits if the chip is not supported one. If that happens
> mskc_detach() will call bus_release_resources() with invalid
> SYS_RES_IRQ resources.

Ah, ok.

-- 
John Baldwin



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200701091117.55545.jhb>