Date: Tue, 14 Jan 2020 22:10:46 -0800 From: Gleb Smirnoff <glebius@freebsd.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Cc: hselasky@freebsd.org, bz@freebsd.org, cem@freebsd.org Subject: Re: svn commit: r356755 - in head/sys: net netinet netinet6 netpfil/ipfw/nat64 sys Message-ID: <20200115061046.GR39529@FreeBSD.org> In-Reply-To: <202001150605.00F65Kc8011526@repo.freebsd.org> References: <202001150605.00F65Kc8011526@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Hi,
On Wed, Jan 15, 2020 at 06:05:20AM +0000, Gleb Smirnoff wrote:
T> Log:
T> Introduce NET_EPOCH_CALL() macro and use it everywhere where we free
T> data based on the network epoch. The macro reverses the argument
T> order of epoch_call(9) - first function, then its argument. NFC
I really want to reverse the argument order of epoch_call() as well.
The current order is really backwards:
void
epoch_call(epoch_t epoch, epoch_context_t ctx,
void (*callback)(epoch_context_t));
Suggested declaration is:
void
epoch_call(epoch_t epoch, epoch_context_t ctx,
void (*callback)(epoch_context_t));
This will be a very easy change, since today function is
used just in few places.
Before branching stable/12 we intentionally put this
note in epoch.9 manual page:
NOTES
The epoch kernel programming interface is under development and is
subject to change.
Any objections?
--
Gleb Smirnoff
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20200115061046.GR39529>