Date: Sun, 02 Apr 2000 20:41:32 +0200 From: Poul-Henning Kamp <phk@critter.freebsd.dk> To: Matthew Dillon <dillon@apollo.backplane.com> Cc: Bruce Evans <bde@zeta.org.au>, "Justin T. Gibbs" <gibbs@FreeBSD.ORG>, cvs-committers@FreeBSD.ORG, cvs-all@FreeBSD.ORG Subject: Re: cvs commit: src/sys/kern kern_mib.c vfs_bio.c src/sys/sys buf.h Message-ID: <15179.954700892@critter.freebsd.dk> In-Reply-To: Your message of "Sun, 02 Apr 2000 10:41:40 PDT." <200004021741.KAA49471@apollo.backplane.com>
next in thread | previous in thread | raw e-mail | index | archive | help
In message <200004021741.KAA49471@apollo.backplane.com>, Matthew Dillon writes: > I agree with Greg's assessment that 32 bit block numbers are starting to > get a bit thin, and given the choice between going to 64 bit block numbers > and 64 bit offsets, he (and I) would rather go to 64 bit offsets. As I said, this is not something I feel strongly about either way, there are pro-et-con for all three solutions, but I don't personally have a preference. It is also pretty much entirely irelevant to the stuff I'm currently doing. In fact I'm trying very hard to *not* change the semantics of any more fields than I absolutely have to. > I would also appreciate it, Poul, if you are going to be so rabid about > me getting my stuff reviewed, I'm not rabid about you getting your stuff reviewed, I'm rabid about you not committing in a frenzy where you forget to do even very basic testing. But with that being said, I'll pretty soon get to the non-trivial part of this change and you will have all the opportunity you will ever want to review huge diffs on my web-page. All the stuff up until here have been very mechanical and not really very reviewable, the next step is where we get the chance to find bugs in drivers :-) I already think I have found two bugs btw: both vn and ccd sets B_INVAL on buffers, I don't belive they have any business doing that. -- Poul-Henning Kamp FreeBSD coreteam member phk@FreeBSD.ORG "Real hackers run -current on their laptop." FreeBSD -- It will take a long time before progress goes too far! To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?15179.954700892>