Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 10 May 2016 17:06:08 +0200
From:      Hans Petter Selasky <hps@selasky.org>
To:        Hans Petter Selasky <hselasky@FreeBSD.org>, src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org
Subject:   Re: svn commit: r299363 - head/sys/compat/linuxkpi/common/include/asm
Message-ID:  <7693af09-def2-e8a7-b7fd-9b6df41908cc@selasky.org>
In-Reply-To: <201605101139.u4ABdaTL098171@repo.freebsd.org>
References:  <201605101139.u4ABdaTL098171@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On 05/10/16 13:39, Hans Petter Selasky wrote:
> Author: hselasky
> Date: Tue May 10 11:39:36 2016
> New Revision: 299363
> URL: https://svnweb.freebsd.org/changeset/base/299363
>
> Log:
>   Use function macros when possible to avoid stray substitutions.
>
>   MFC after:	1 week
>   Sponsored by:	Mellanox Technologies
>

FYI

This change accidentially broke LINT and I have a patch waiting for 
review from the Chelsio guys that will fix LINT and WITH_OFED=YES again. 
Will hopefully be fixed shortly.

> Index: sys/dev/cxgb/cxgb_osdep.h
> ===================================================================
> --- sys/dev/cxgb/cxgb_osdep.h	(revision 299261)
> +++ sys/dev/cxgb/cxgb_osdep.h	(working copy)
> @@ -169,7 +169,7 @@
>  #define test_and_clear_bit(bit, p) atomic_cmpset_int((p), ((*(p)) | (1<<bit)), ((*(p)) & ~(1<<bit)))
>
>  #define max_t(type, a, b) (type)max((a), (b))
> -#define cpu_to_be32            htobe32
> +#define cpu_to_be32(x)		htobe32(x)
>
>  /* Standard PHY definitions */
>  #define BMCR_LOOPBACK		BMCR_LOOP

--HPS




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?7693af09-def2-e8a7-b7fd-9b6df41908cc>