Date: Wed, 14 Dec 2011 11:52:55 GMT From: Rene Ladan <rene@FreeBSD.org> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/163282: bsd.port.mk : remove stale MD5 definition Message-ID: <201112141152.pBEBqtsQ011337@red.freebsd.org> Resent-Message-ID: <201112141200.pBEC0aGF025997@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 163282
>Category: ports
>Synopsis: bsd.port.mk : remove stale MD5 definition
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed Dec 14 12:00:36 UTC 2011
>Closed-Date:
>Last-Modified:
>Originator: Rene Ladan
>Release: FreeBSD 10.0/am64
>Organization:
>Environment:
FreeBSD 10.0/amd64, current Ports Tree
>Description:
I noticed an unused definition of an MD5 variable in bsd.port.mk, so remove it.
While here remove a comment about md5 being deprecated in the description of CHECKSUM_ALGORITHMS
>How-To-Repeat:
>Fix:
Patch attached with submission follows:
Index: bsd.port.mk
===================================================================
RCS file: /home/pcvs/ports/Mk/bsd.port.mk,v
retrieving revision 1.699
diff -u -r1.699 bsd.port.mk
--- bsd.port.mk 9 Nov 2011 08:53:12 -0000 1.699
+++ bsd.port.mk 14 Dec 2011 11:46:48 -0000
@@ -1098,7 +1098,7 @@
# - Different checksum algorithms to check for verifying the
# integrity of the distfiles. The absence of the algorithm
# in distinfo doesn't make it fail.
-# Default: sha256 (md5 is deprecated, allowed but unused)
+# Default: sha256
# NO_CHECKSUM - Don't verify the checksum. Typically used when
# when you noticed the distfile you just fetched has
# a different checksum and you intend to verify if
@@ -4776,8 +4776,7 @@
done; \
checksum_init=\
- SHA256=${SHA256}; \
- MD5=${MD5};
+ SHA256=${SHA256};
.if !target(makesum)
makesum: check-checksum-algorithms
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201112141152.pBEBqtsQ011337>