Date: Wed, 4 Dec 2019 04:47:27 +0100 From: Mateusz Guzik <mjguzik@gmail.com> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r355241 - head/sys/kern Message-ID: <CAGudoHHi5abyKd8iJb6tgkrEBZWRqNrdgHODPqVJAZTWPzHo5w@mail.gmail.com> In-Reply-To: <6cd7168c-8212-3001-fb8f-09ecaca93e61@FreeBSD.org> References: <201911301933.xAUJX2DB030548@repo.freebsd.org> <6cd7168c-8212-3001-fb8f-09ecaca93e61@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 12/2/19, John Baldwin <jhb@freebsd.org> wrote: > On 11/30/19 11:33 AM, Mateusz Guzik wrote: >> Author: mjg >> Date: Sat Nov 30 19:33:02 2019 >> New Revision: 355241 >> URL: https://svnweb.freebsd.org/changeset/base/355241 >> >> Log: >> smp: cast the read in quiesce_all_critical through void * >> >> Fixes compilation on some 32-bit arm platforms. >> >> Sponsored by: The FreeBSD Foundation >> >> Modified: >> head/sys/kern/subr_smp.c >> >> Modified: head/sys/kern/subr_smp.c >> ============================================================================== >> --- head/sys/kern/subr_smp.c Sat Nov 30 19:21:29 2019 (r355240) >> +++ head/sys/kern/subr_smp.c Sat Nov 30 19:33:02 2019 (r355241) >> @@ -952,7 +952,7 @@ quiesce_all_critical(void) >> break; >> cpu_spinwait(); >> newtd = (struct thread *) >> - atomic_load_acq_ptr((u_long *)pcpu->pc_curthread); >> + atomic_load_acq_ptr((void *)pcpu->pc_curthread); > > Why not uintptr_t *? I think that's the defined type for atomic_*_ptr > anyway? > I have no strong opinion one way or the other. However, the real fix would make these routines work without casting for cases like the above. -- Mateusz Guzik <mjguzik gmail.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGudoHHi5abyKd8iJb6tgkrEBZWRqNrdgHODPqVJAZTWPzHo5w>