Skip site navigation (1)Skip section navigation (2)
Date:      Wed, 16 Jun 2010 11:21:20 -0500
From:      Alan Cox <alc@cs.rice.edu>
To:        Pawel Jakub Dawidek <pjd@FreeBSD.org>
Cc:        Alan Cox <alc@FreeBSD.org>, svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r209226 - head/sys/fs/tmpfs
Message-ID:  <4C18FA00.3050804@cs.rice.edu>
In-Reply-To: <20100616124346.GI1739@garage.freebsd.pl>
References:  <201006160041.o5G0fLvZ041271@svn.freebsd.org> <20100616124346.GI1739@garage.freebsd.pl>

next in thread | previous in thread | raw e-mail | index | archive | help
On 6/16/2010 7:43 AM, Pawel Jakub Dawidek wrote:
> On Wed, Jun 16, 2010 at 12:41:21AM +0000, Alan Cox wrote:
>    
>> Author: alc
>> Date: Wed Jun 16 00:41:21 2010
>> New Revision: 209226
>> URL: http://svn.freebsd.org/changeset/base/209226
>>
>> Log:
>>    Eliminate unnecessary page queues locking.
>>      
> [...]
>
> Could you take a look at this patch:
>
> 	http://people.freebsd.org/~pjd/patches/zfs_vnops.c.4.patch
>
>    

The patch is correct.  Go ahead and commit it.

Couldn't this function be simplified a little using uiomove_fromphys() 
instead of sf_buf_alloc() and uiomove()?  One effect would be the 
elimination of the pinning that isn't needed by amd64 (and other 
architectures that have a direct map).

Alan




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4C18FA00.3050804>