Skip site navigation (1)Skip section navigation (2)
Date:      Thu, 15 Dec 2011 09:02:48 +0100
From:      Bernhard Schmidt <bschmidt@freebsd.org>
To:        Adrian Chadd <adrian@freebsd.org>
Cc:        svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org
Subject:   Re: svn commit: r228514 - head/sys/net80211
Message-ID:  <CAAgh0_avwsQ7uzEnwxKtDnnGjck7tJ5AkjqhBYrz2NuRivbbAg@mail.gmail.com>
In-Reply-To: <201112150052.pBF0qUA5022051@svn.freebsd.org>
References:  <201112150052.pBF0qUA5022051@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Dec 15, 2011 at 01:52, Adrian Chadd <adrian@freebsd.org> wrote:
> Author: adrian
> Date: Thu Dec 15 00:52:30 2011
> New Revision: 228514
> URL: http://svn.freebsd.org/changeset/base/228514
>
> Log:
> =A0Modify the ACL code slightly to support a few nifty things:
>
> =A0* Call it before sending probe responses, so the ACL code has the
> =A0 =A0chance to reject sending them.
>
> =A0* Pass the whole frame to the ACL code now, rather than just the
> =A0 =A0destination MAC - that way the ACL module can look at the frame
> =A0 =A0contents to determine what the response should be.
>
> =A0This is part of some uncommitted work to support band steering.
>
> =A0Sponsored by: Hobnob, Inc.
>
> Modified:
> =A0head/sys/net80211/ieee80211_acl.c
> =A0head/sys/net80211/ieee80211_hostap.c
> =A0head/sys/net80211/ieee80211_mesh.c
> =A0head/sys/net80211/ieee80211_proto.h
>
> Modified: head/sys/net80211/ieee80211_acl.c
> =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=
=3D=3D=3D=3D
> --- head/sys/net80211/ieee80211_acl.c =A0 Wed Dec 14 23:57:47 2011 =A0 =
=A0 =A0 =A0(r228513)
> +++ head/sys/net80211/ieee80211_acl.c =A0 Thu Dec 15 00:52:30 2011 =A0 =
=A0 =A0 =A0(r228514)
> @@ -152,7 +152,8 @@ _acl_free(struct aclstate *as, struct ac
> =A0}
>
> =A0static int
> -acl_check(struct ieee80211vap *vap, const uint8_t mac[IEEE80211_ADDR_LEN=
])
> +acl_check(struct ieee80211vap *vap, const struct ieee80211_frame *wh,
> + =A0 =A0const uint8_t mac[IEEE80211_ADDR_LEN])
> =A0{

Why didn't you remove the mac argument? It is assign from wh->i_addr2
anyways, seems rather too redundant to me.

--=20
Bernhard



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAAgh0_avwsQ7uzEnwxKtDnnGjck7tJ5AkjqhBYrz2NuRivbbAg>