Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 26 Dec 2017 07:16:26 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Jan Beich <jbeich@FreeBSD.org>
Cc:        ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org
Subject:   Re: svn commit: r457245 - in head/net-p2p: bitcoin litecoin
Message-ID:  <20171226071626.GC27490@FreeBSD.org>
In-Reply-To: <201712251807.vBPI7mAd012038@repo.freebsd.org>
References:  <201712251807.vBPI7mAd012038@repo.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 25, 2017 at 06:07:48PM +0000, Jan Beich wrote:
> New Revision: 457245
> URL: https://svnweb.freebsd.org/changeset/ports/457245
> 
> Log:
>   net-p2p/bitcoin: unbreak with boost 1.66
>   
>   PR:		224129 224132
>   Obtained from:	upstream (Bitcoin 0.16.0)
>   Approved by:	portmgr blanket
> 
> Modified: head/net-p2p/bitcoin/Makefile
> ...
> @@ -7,6 +7,9 @@ DISTVERSIONPREFIX=	v
>  PORTREVISION?=	2
>  CATEGORIES=	net-p2p finance
>  
> +PATCH_SITES=	https://github.com/${GH_ACCOUNT}/${GH_PROJECT}/commit/
> +PATCHFILES=	1ec0c0a01c31.patch:-p1
...
> 
> Modified: head/net-p2p/bitcoin/distinfo
> ...
> +SIZE (1ec0c0a01c31.patch) = 3535

I'd like to bring to your attention (again) that this approach of fetching
external patches is fragile and already had broken things in the past.
Putting 3535-byte patch file in ${FILESDIR} is perfectly fine for its size
(and EXTRA_PATCHES also supports :-p1).

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20171226071626.GC27490>