Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 06 Oct 2019 09:23:23 +0000
From:      bugzilla-noreply@freebsd.org
To:        ports-bugs@FreeBSD.org
Subject:   [Bug 240138] [NEW PORT] sysutils/libudisks: Library from udisks project, to access and manipulate disks, storage devices and technologies
Message-ID:  <bug-240138-7788-fhMdUS6Yoy@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-240138-7788@https.bugs.freebsd.org/bugzilla/>
References:  <bug-240138-7788@https.bugs.freebsd.org/bugzilla/>

next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D240138

--- Comment #18 from Ting-Wei Lan <lantw44@gmail.com> ---
Comment on attachment 208102
  --> https://bugs.freebsd.org/bugzilla/attachment.cgi?id=3D208102
Patch for new port sysutils/libudisks

>+# pkaction takes care of libpolkit-agent-1 and libpolkit-gobject-1
>+# which are what we really want (see UDISKSCTL_LIB_DEPENDS).
>+BUILD_DEPENDS=3D	bash:shells/bash gtkdocize:textproc/gtk-doc \

Is there any reason to put two dependencies in one line here?

>+OPTIONS_DEFINE=3D	UDISKSCTL
>+OPTIONS_SUB=3D	yes
>+UDISKSCTL_DESC=3D	Install udisksctl command line utility
>+UDISKSCTL_LIB_DEPENDS=3D	libpolkit-agent-1.so:sysutils/polkit \
>+			libpolkit-gobject-1.so:sysutils/polkit

Can we enable UDISKSCTL by default? It is just a small tool that is useful =
for
testing. It also makes the port similar to the upstream default because the
upstream project doesn't have an option to disable udisksctl.

>+
>+# config.status errors out without --disable-dependency-tracking, with or
>+# without USES=3Dgmake.
>+do-configure:
>+	cd ${WRKSRC} && \
>+	./autogen.sh --disable-daemon --disable-gtk-doc --disable-nls \

Why --disable-nls is used? If you think NLS should be optional, put it under
NLS option. NLS is enabled by default. --disable-gtk-doc should also be
optional, so users can decide if the documentation is needed.

--=20
You are receiving this mail because:
You are the assignee for the bug.=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-240138-7788-fhMdUS6Yoy>