Date: Thu, 11 Feb 2010 19:25:31 -0500 From: "Philip M. Gollucci" <pgollucci@p6m7g8.com> To: Doug Barton <dougb@FreeBSD.org> Cc: cvs-ports@FreeBSD.org, Alexey Dokuchaev <danfe@FreeBSD.org>, Dmitry Marakasov <amdmi3@amdmi3.ru>, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org Subject: Re: cvs commit: ports/audio Makefile ports/audio/deadbeef Makefile distinfo pkg-descr pkg-plist ports/audio/deadbeef/files patch-Makefile.am patch-Makefile.in patch-configure patch-configure.ac Message-ID: <4B749FFB.80506@p6m7g8.com> In-Reply-To: <4B749F6E.5020806@FreeBSD.org> References: <201002092323.o19NNRvB090976@repoman.freebsd.org> <20100210092407.GA30717@FreeBSD.org> <20100210125022.GD1538@hades.panopticon> <4B749F6E.5020806@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On 2/11/2010 7:23 PM, Doug Barton wrote: > On 02/10/10 04:50, Dmitry Marakasov wrote: >>>> 1.1 +13 -0 ports/audio/deadbeef/files/patch-Makefile.am >>>> (new) >>>> 1.1 +21 -0 ports/audio/deadbeef/files/patch-Makefile.in >>>> (new) > Doug Since when? I've not once in 2 yrs seen someone patch both. What I do know is that we *try* to always patch the .am/.ac files and use USE_AUTOTOOLS to re-generate the .in files. AFAIK, this is to keep the diffs *actually* reviewable. Can you point to another port that patches both? If so, I'll update my work flow to do it too. -- ------------------------------------------------------------------------ 1024D/DB9B8C1C B90B FBC3 A3A1 C71A 8E70 3F8C 75B8 8FFB DB9B 8C1C Philip M. Gollucci (pgollucci@p6m7g8.com) c: 703.336.9354 VP Apache Infrastructure; Member, Apache Software Foundation Committer, FreeBSD Foundation Sr. System Admin, Ridecharge Inc. Consultant, P6M7G8 Inc. Work like you don't need the money, love like you'll never get hurt, and dance like nobody's watching.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?4B749FFB.80506>