Date: Wed, 23 Jun 2010 23:13:40 -0700 (PDT) From: Don Lewis <truckman@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Subject: ports/148101: x11/startup-notification Makefile missing library dependencies [patch] Message-ID: <201006240613.o5O6DeIh006422@mousie.catspoiler.org> Resent-Message-ID: <201006240630.o5O6U5rJ046633@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 148101
>Category: ports
>Synopsis: x11/startup-notification Makefile missing library dependencies [patch]
>Confidential: no
>Severity: non-critical
>Priority: medium
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Thu Jun 24 06:30:05 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator: Don Lewis
>Release: FreeBSD 8.1-PRERELEASE i386
>Organization:
self
>Environment:
System: FreeBSD scratch.catspoiler.org 8.1-PRERELEASE FreeBSD 8.1-PRERELEASE #1: Sun Jun 13 00:47:16 PDT 2010 dl@scratch.catspoiler.org:/usr/obj/usr/src/sys/GENERICDDB i386
>Description:
The Makefile for the x11/startup-notification port does not
list all of the library dependencies used by the port.
When reinstalling all of the previously installed ports after a
major FreeBSD release upgrade using "portupgrade -N", portupgrade
might attempt to build x11/startup-notification before all of its
dependencies have been installed, which will cause the build to
fail.
libtool: link: cc -O2 -pipe -fno-strict-aliasing -Wall -o .libs/test-watch-xmessages-xcb test-watch-xmessages-xcb.o -L/usr/local/lib ../libsn/.libs/libstartup-notification-1.so /usr/local/lib/libxcb-aux.so /usr/local/lib/libxcb-event.so /usr/local/lib/libxcb-atom.so /usr/local/lib/libSM.so /usr/local/lib/libICE.so /usr/local/lib/libX11.so /usr/local/lib/libxcb.so /usr/local/lib/libXau.so /usr/local/lib/libXdmcp.so /usr/local/lib/libpthread-stubs.so -lrpcsvc -Wl,-rpath -Wl,/usr/local/lib
>How-To-Repeat:
Remove the containing one of the libraries that startup-notification
links against (such as x11/libSM) and attempt to build
startup-notification.
>Fix:
Index: Makefile
===================================================================
RCS file: /home/ncvs/ports/x11/startup-notification/Makefile,v
retrieving revision 1.28
diff -u -r1.28 Makefile
--- Makefile 2 Aug 2009 19:36:11 -0000 1.28
+++ Makefile 24 Jun 2010 05:44:08 -0000
@@ -15,8 +15,12 @@
COMMENT= Library that supports startup notification spec from freedesktop.org
LIB_DEPENDS= xcb-aux.0:${PORTSDIR}/x11/xcb-util
+BUILD_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/pthread-stubs.pc:${PORTSDIR}/devel/libpthread-stubs \
+ ${LOCALBASE}/libdata/pkgconfig/xcb.pc:${PORTSDIR}/x11/libxcb
+RUN_DEPENDS= ${LOCALBASE}/libdata/pkgconfig/pthread-stubs.pc:${PORTSDIR}/devel/libpthread-stubs \
+ ${LOCALBASE}/libdata/pkgconfig/xcb.pc:${PORTSDIR}/x11/libxcb
-USE_XORG= x11
+USE_XORG= ice sm xau xdmcp x11
USE_AUTOTOOLS= libtool:22
USE_GMAKE= yes
USE_GNOME= gnomehack gnometarget pkgconfig
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201006240613.o5O6DeIh006422>