Date: Tue, 7 Nov 2006 01:34:49 GMT From: Sam Leffler <sam@FreeBSD.org> To: Perforce Change Reviews <perforce@freebsd.org> Subject: PERFORCE change 109410 for review Message-ID: <200611070134.kA71Yn88090377@repoman.freebsd.org>
next in thread | raw e-mail | index | archive | help
http://perforce.freebsd.org/chv.cgi?CH=109410 Change 109410 by sam@sam_ebb on 2006/11/07 01:34:29 Track npe msg handling changes: must now drop the softc lock around calls to collect status as otherwise we'd be holding the softc lock when ixpnpe_sendandrecvmsg sleeps. Note: we get input fifo polling timeouts when setting up rx qids for traffic classes 4-7; will investigate but things appear to otherwise work Affected files ... .. //depot/projects/arm/src/sys/arm/xscale/ixp425/if_npe.c#6 edit Differences ... ==== //depot/projects/arm/src/sys/arm/xscale/ixp425/if_npe.c#6 (text+ko) ==== @@ -654,7 +654,11 @@ struct npestats *ns = sc->sc_stats; NPE_ASSERT_LOCKED(sc); + + NPE_UNLOCK(sc); /* XXX */ npe_updatestats(sc); /* update + clear stats */ + NPE_LOCK(sc); + bus_dmamap_sync(sc->sc_stats_tag, sc->sc_stats_map, BUS_DMASYNC_POSTREAD); @@ -688,9 +692,7 @@ + be32toh(ns->RxUnderflowEntryDiscards) ; - /* - * Schedule another timeout one second from now. - */ + /* schedule next poll */ callout_reset(&sc->tick_ch, hz, npe_tick, sc); #undef MIBADD }
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200611070134.kA71Yn88090377>