Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 13 Dec 2005 20:55:32 GMT
From:      Gavin Atkinson <gavin.atkinson@ury.york.ac.uk>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   bin/90353: [patch] Incorrect usage() in atacontrol
Message-ID:  <200512132055.jBDKtWrP004569@945testbox.york.ac.uk>
Resent-Message-ID: <200512132100.jBDL0E3W005072@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         90353
>Category:       bin
>Synopsis:       [patch] Incorrect usage() in atacontrol
>Confidential:   no
>Severity:       non-critical
>Priority:       low
>Responsible:    freebsd-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Tue Dec 13 21:00:14 GMT 2005
>Closed-Date:
>Last-Modified:
>Originator:     Gavin Atkinson
>Release:        FreeBSD 7.0-CURRENT i386
>Organization:
>Environment:
System: FreeBSD 945testbox.york.ac.uk 7.0-CURRENT FreeBSD 7.0-CURRENT #0: Mon Dec 12 18:04:02 GMT 2005 root@945testbox.york.ac.uk:/usr/obj/usr/src/sys/GENERIC i386

>Description:
	The help page printed out by atacontrol when arguments are
incorrect is wrong in the definition of the "delete" command - it
is used to delete arrays not channels, and therefore takes an array
name as its argument rather than a channel.  The man page is correct.

>How-To-Repeat:
	Try to delete a channel, or an array.

>Fix:

--- atacontrol-delarray.diff begins here ---
Index: src/sbin/atacontrol/atacontrol.c
===================================================================
RCS file: /usr/cvs/src/sbin/atacontrol/atacontrol.c,v
retrieving revision 1.37
diff -p -u -r1.37 atacontrol.c
--- src/sbin/atacontrol/atacontrol.c	5 Aug 2005 13:08:02 -0000	1.37
+++ src/sbin/atacontrol/atacontrol.c	13 Dec 2005 20:50:23 -0000
@@ -103,7 +103,7 @@ usage()
 		"        atacontrol detach channel\n"
 		"        atacontrol reinit channel\n"
 		"        atacontrol create type [interleave] disk0 ... diskN\n"
-		"        atacontrol delete channel\n"
+		"        atacontrol delete array\n"
 		"        atacontrol addspare array disk\n"
 		"        atacontrol rebuild array\n"
 		"        atacontrol status array\n"
--- atacontrol-delarray.diff ends here ---


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200512132055.jBDKtWrP004569>