Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 22 Dec 1997 03:26:20 +1100
From:      Bruce Evans <bde@zeta.org.au>
To:        bde@zeta.org.au, max@wide.ad.jp
Cc:        cvs-all@FreeBSD.ORG, cvs-committers@FreeBSD.ORG, cvs-sys@FreeBSD.ORG, eivind@FreeBSD.ORG
Subject:   Re: cvs commit: src/sys/net if_slvar.h
Message-ID:  <199712211626.DAA17627@godzilla.zeta.org.au>

next in thread | raw e-mail | index | archive | help
>     > It was.  This is slattach.c's fault for including a private
>     > header.  It wasn't even used.
>
>I found the same problem with startslip.c.

It also has the same disorder and even more unused includes than slattach.

Bruce

diff -c2 startslip.c~ startslip.c
*** startslip.c~	Sat Jun 21 15:56:11 1997
--- startslip.c	Mon Dec 22 03:13:49 1997
***************
*** 45,56 ****
  
  #include <sys/types.h>
- #include <sys/ioctl.h>
- #include <sys/socket.h>
  #include <sys/time.h>
  
  #include <errno.h>
  #include <fcntl.h>
  #include <paths.h>
- #include <netdb.h>
  #include <signal.h>
  #include <stdio.h>
--- 45,55 ----
  
  #include <sys/types.h>
  #include <sys/time.h>
  
+ #include <err.h>
  #include <errno.h>
  #include <fcntl.h>
+ #include <libutil.h>
  #include <paths.h>
  #include <signal.h>
  #include <stdio.h>
***************
*** 61,71 ****
  #include <time.h>
  #include <unistd.h>
- #include <libutil.h>
- #include <err.h>
  
- #include <netinet/in.h>
- #include <net/if.h>
- #include <net/if_var.h>
- #include <net/if_slvar.h>
  #include <net/slip.h>
  
--- 60,64 ----



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199712211626.DAA17627>