Skip site navigation (1)Skip section navigation (2)
Date:      Tue, 29 Jan 2013 22:09:11 -0800
From:      Jason Helfman <bsd-src@helfman.org>
To:        Alexey Dokuchaev <danfe@FreeBSD.org>
Cc:        "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Boris Samorodov <bsam@passap.ru>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r311165 - head/Mk
Message-ID:  <5ABB3D0B-E709-4BD0-A537-26DAA143E64C@helfman.org>
In-Reply-To: <20130130055308.GA78903@FreeBSD.org>
References:  <201301291333.r0TDXuR1014841@svn.freebsd.org> <5108AA30.1000507@passap.ru> <20130130055308.GA78903@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Jan 29, 2013, at 9:53 PM, Alexey Dokuchaev <danfe@FreeBSD.org> wrote:

> On Wed, Jan 30, 2013 at 09:05:52AM +0400, Boris Samorodov wrote:
>> 29.01.2013 17:33, Alexey Dokuchaev =D0=BF=D0=B8=D1=88=D0=B5=D1=82:
>>=20
>>> +ZSH_DESC?=3D        Install programmable completions for zsh
>>=20
>> May be this variable should be ZSH_COMPLETION_DESC or like?
>> I'd say that current variable name should be used for the
>> shell itself.
>=20
> Yes, variable name is indeed a bit vague.  I've decided to follow the BASH=

> example for two reasons: 1) consistency; 2) it is not immediately obvious t=
o
> me how else a shall can be supported, given that both bash and zsh do not
> provide a way to embed themselves anywhere.
>=20
>> Or for consistency with bash (since bash is one character longer), say:
>> ZSH_COMPLETS_DESC
>> BASH_COMPLETS_DESC
>=20
> I think these are quite ugly; I've tried to come up with something like
> this and failed.  FOOSH_COMP_DESC is the least ugly I can imagine.
>=20
> ./danfe
>=20

What you've chosen I believe is the best path, as it is general enough to ad=
opt for N+1 choices by altering the desc. Narrowing the identifier will at l=
east lead to more identifiers being committed, or a confusing description at=
tached to what has been suggested.

-jgh=



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?5ABB3D0B-E709-4BD0-A537-26DAA143E64C>