Date: Fri, 26 Apr 2002 00:34:20 -0400 From: Mike Barcroft <mike@FreeBSD.ORG> To: Garance A Drosihn <drosih@rpi.edu> Cc: "M. Warner Losh" <imp@village.org>, arch@FreeBSD.ORG, freebsd-standards@FreeBSD.ORG Subject: Re: diff & patch problem with 'No newline' Message-ID: <20020426003420.D43192@espresso.q9media.com> In-Reply-To: <p05111719b8ee8447f9d3@[128.113.24.47]>; from drosih@rpi.edu on Fri, Apr 26, 2002 at 12:17:44AM -0400 References: <p05101422b88ba26bec5e@[128.113.24.47]> <p05111715b8ee4710a108@[128.113.24.47]> <20020425210035.A43192@espresso.q9media.com> <20020425.202217.82927028.imp@village.org> <20020426000849.C43192@espresso.q9media.com> <p05111719b8ee8447f9d3@[128.113.24.47]>
next in thread | previous in thread | raw e-mail | index | archive | help
Garance A Drosihn <drosih@rpi.edu> writes: > >Perhaps the people working on Subversion still have time > >to fix that design before too many people start using it. > >Solaris 2.5.1, for instance, returns "Warning: missing > >newline at end of file" on stderr for this condition. > > They probably will fix it, by writing their own diff and > their own patch. The same way other packages fix it, > by requiring that the user install gnu-diff & gnu-patch. It occurs to me that the name of this software is very appropriate. In any event, we'll be in good company if they decide to reject convention and go the Linux-route. > I am still wondering who it is that is better off given > the standard behavior than this particular non-standard > behavior. Not "better off" in the sense that "it is > better to follow standards", but "better off" in the > sense that it is easier to get their work done, and the > sun shines brighter, and beer tastes better -- all > because the standard does not allow patch+diff to > handle this simple case of a file which is missing the > last newline character. It may be that my reading of the specification is too strict. There's nothing in the Standard that deals with this edge case, so anything you do will be non-standard. I just happen to think, garbage in the outputted diff is the worst possible choice. Best regards, Mike Barcroft To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20020426003420.D43192>