Date: 7 May 2008 10:28:46 -0300 From: Renato Botelho <garga@FreeBSD.org> To: FreeBSD-gnats-submit@FreeBSD.org Cc: des@FreeBSD.org Subject: ports/123490: [PATCH] shells/zsh: Fix segmentation fault on completion Message-ID: <20080507132846.26249.qmail@soc90.bluepex.com> Resent-Message-ID: <200805071330.m47DU1AE010204@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 123490
>Category: ports
>Synopsis: [PATCH] shells/zsh: Fix segmentation fault on completion
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Wed May 07 13:30:01 UTC 2008
>Closed-Date:
>Last-Modified:
>Originator: Renato Botelho
>Release: FreeBSD 7.0-STABLE i386
>Organization:
FreeBSD.org
>Environment:
System: FreeBSD botelhor.bplab.local 7.0-STABLE FreeBSD 7.0-STABLE #25: Fri May 2 11:38:54 BRT
>Description:
This patch was obtained from zsh-workers list and fix a segfault problem on completion
Added file(s):
- files/patch-Src_Zle_compresult.c
Port maintainer (des@FreeBSD.org) is cc'd.
Generated with FreeBSD Port Tools 0.77
>How-To-Repeat:
zsh -f
q<TAB><TAB><^D><^D>
>Fix:
--- zsh-4.3.6_1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/shells/zsh/Makefile,v
retrieving revision 1.94
diff -u -u -r1.94 Makefile
--- Makefile 6 May 2008 11:52:45 -0000 1.94
+++ Makefile 7 May 2008 13:27:31 -0000
@@ -22,6 +22,7 @@
PORTNAME= zsh
PORTVERSION= 4.3.6
+PORTREVISION= 1
CATEGORIES= shells
MASTER_SITES= SF
.if !defined(NOPORTDOCS)
Index: files/patch-Src_Zle_compresult.c
===================================================================
RCS file: files/patch-Src_Zle_compresult.c
diff -N files/patch-Src_Zle_compresult.c
--- /dev/null 1 Jan 1970 00:00:00 -0000
+++ files/patch-Src_Zle_compresult.c 7 May 2008 13:27:31 -0000
@@ -0,0 +1,28 @@
+--- Src/Zle/compresult.c.orig 2008-05-07 10:19:11.000000000 -0300
++++ Src/Zle/compresult.c 2008-05-07 10:19:35.000000000 -0300
+@@ -1188,6 +1188,12 @@
+ {
+ int was_meta;
+
++ /* Just list the matches if the list was requested. */
++ if (lst == COMP_LIST_COMPLETE) {
++ showinglist = -2;
++ return;
++ }
++
+ /* Already metafied when called from domenuselect already */
+ if (zlemetaline == NULL) {
+ was_meta = 0;
+@@ -1195,12 +1201,6 @@
+ } else
+ was_meta = 1;
+
+- /* Just list the matches if the list was requested. */
+- if (lst == COMP_LIST_COMPLETE) {
+- showinglist = -2;
+- return;
+- }
+-
+ /* Otherwise go to the next match in the array... */
+ do {
+ if (!*++(minfo.cur)) {
--- zsh-4.3.6_1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20080507132846.26249.qmail>