Date: Thu, 14 Feb 2019 12:48:02 -0800 From: Juli Mallett <juli@northcloak.com> To: rgrimes@freebsd.org Cc: Mark Johnston <markj@freebsd.org>, Warner Losh <imp@bsdimp.com>, Warner Losh <imp@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r344129 - head Message-ID: <CAGSiXYyjSG7Hq-2mWXyc5qWwpNm1FMVhT8XwF5EEhSPnCw_G%2Bg@mail.gmail.com> In-Reply-To: <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net> References: <20190214191329.GB50900@raichu> <201902142042.x1EKgSwf087717@pdx.rh.CN85.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, 14 Feb 2019 at 12:42, Rodney W. Grimes < freebsd@pdx.rh.cn85.dnsmgr.net> wrote: > > On Thu, Feb 14, 2019 at 12:00:22PM -0700, Warner Losh wrote: > > > On Thu, Feb 14, 2019 at 11:29 AM Rodney W. Grimes < > > > > > Differential Review: https://reviews.freebsd.org/D19193 > > > > > > > > You sited a differential, but not give any attribution > > > > to the external source :-( > > > > > > > > > > The differential review has that information. > > > > External contributors should be recognized by having their names appear > > in the commit logs. > > We even bother to put a special line in the commit template > for this. Further it has been standard operating procedure > for at least as long as I have been back that submitters > are infact recognized in commit messages. > Yeah, Phabricator must not become a second source of truth for who actually did the work, which we had at least one case of recently. That's no good. In this case, the difference between a patch and a bug report is indistinguishable ("word X is misspelt at offset Y in file Z" is probably not really Phabricator fodder at the scale of a single instance), but it should plainly either be a Reported byline if not a Submitted one in the commit message itself. Juli.
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAGSiXYyjSG7Hq-2mWXyc5qWwpNm1FMVhT8XwF5EEhSPnCw_G%2Bg>