Date: Sun, 13 Sep 2009 22:23:50 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: freebsd-fs@FreeBSD.org Subject: Review request for NFS readdirplus change. Message-ID: <20090913202350.GE2091@garage.freebsd.pl>
next in thread | raw e-mail | index | archive | help
--xJK8B5Wah2CMJs8h Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hi. I'm looking for a review of the following patch: http://people.freebsd.org/~pjd/patches/nfs_serv.c.3.patch The main purpose of this patch is to support stuff like ZFS, where using VFS_VGET() might be tricky on .zfs/ directory and friends. When VFS_VGET() is not supported be the underlying file system, we switch to VOP_LOOKUP(). Note that OpenSolaris NFS server implementation always uses lookup for readdirplus. I also modified the code to use shared-locking, there is no need to exclusively lock the vnodes. The patch removes an assert which doesn't hold for ZFS when we go into =2Ezfs/snapshot/<name>/ directory, which is separate mount point, but we don't want to export it separately, so we still return it on lookup. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --xJK8B5Wah2CMJs8h Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.4 (FreeBSD) iD8DBQFKrVTWForvXbEpPzQRApcpAKCjYe9Fx6bqf04Ox7DhNUEfnwgKyACfQHe+ EccHmQhVFlUAxYn7OY3KaNI= =IrPL -----END PGP SIGNATURE----- --xJK8B5Wah2CMJs8h--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090913202350.GE2091>