Date: Mon, 2 Jul 2018 21:21:20 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: Sean Chittenden <seanc@FreeBSD.org> Cc: ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org Subject: Re: svn commit: r473756 - head/security/teleport Message-ID: <20180702192120.bmrv74c4atutx26b@atuin.in.mat.cc> In-Reply-To: <201807021659.w62GxDgI031531@repo.freebsd.org> References: <201807021659.w62GxDgI031531@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--ntslk7urmefcbfjr Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Jul 02, 2018 at 04:59:13PM +0000, Sean Chittenden wrote: > Author: seanc > Date: Mon Jul 2 16:59:13 2018 > New Revision: 473756 > URL: https://svnweb.freebsd.org/changeset/ports/473756 >=20 > Log: > Optimize teleport build further and reuse the same sed invocation. > =20 > Submitted by: mat > Approved by: mat (mentor, implicit) > Pointy hat: seanc >=20 > Modified: > head/security/teleport/Makefile >=20 > Modified: head/security/teleport/Makefile > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D > --- head/security/teleport/Makefile Mon Jul 2 16:45:53 2018 (r473755) > +++ head/security/teleport/Makefile Mon Jul 2 16:59:13 2018 (r473756) > @@ -45,9 +45,9 @@ post-extract: > post-patch: > @${REINPLACE_CMD} -e 's|^GITREF=3D.*|GITREF=3D${GH_TAG_COMMIT}|' \ > ${WRKDIR}/${GO_TELEPORT_SRC_DIR}/version.mk > - @${FIND} ${WRKDIR} -type f \ > - -exec ${SED} -i '' -e 's|\/var\/lib|/var/db|g' {} \; \ > - -exec ${SED} -i '' -e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \; > + @${FIND} ${WRKDIR} -type f -exec ${SED} -i '' \ > + -e 's|\/var\/lib|/var/db|g' \ > + -e 's|\/usr\/bin\/hostname|/bin/hostname|g' {} \; Now, you are only running one sed for each file in WRKDIR instead of two. Let's cut that down to only one sed call for all the files, please replace "\;" with "+". --=20 Mathieu Arnold --ntslk7urmefcbfjr Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAABCgB9FiEEOraXidLtEhBkQLpbOkUW81GDzkgFAls6ey9fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNB QjY5Nzg5RDJFRDEyMTA2NDQwQkE1QjNBNDUxNkYzNTE4M0NFNDgACgkQOkUW81GD zkj4vhAAvkVJWJtiVXFxn/sLkCFb1mo58aUJXdavLUi8hu9lVG6krUB6jew7U+mK EJlGJ9hoosPNKxgxahtHr1gbWQoWFXlGpo2emU+jLCEF2Mij67boCeb6xATFN330 aONLTdOjPHbqOnbRWe+I+x7hTafkkSgEb0RFUp0d4j662C34n7rRUV5a3qEkSFaq H2txoucDdREmMeaGpo3IjLrJYwLkufWTS84W3dHhRwP7et4swJNshWiQ/HtyfNR8 z+q0nVbyzVKVHNfZw6rv+Rpcer8JCkmeSNaSGZ8h6+3z9e/hYkDoQFatlswQ8sFy 47oEu8aJ7yp+6nDe3W+lARTwzWLIY2AV1ycvVyKTeFUa7QhSJ7DnFH50Pm848cka V8VYgh52CJ9BaZrhewatsDz0WAslr8v3RcEI8Eff1s8e22zHSo0x5R1HQxmsKOHl 9rkJogbCKwoYdn4MG3BO3H9/pyO1+OujbtBgqaQsf6i30I14Yo4b5i0iZwmeMmyr 4fADIOPcxIO/1QdqV3btodm7Io3y2HMiVODq8V4TkPP0hFh39uY/9tPHaJwBtS32 gRniAJyC00rNRUvcjEZrYQpu0FIYOVs9L4m/b7tjgc3fpti7dXLnMlEoM9mqPYfP y0bwJouENsvAV2l+WJXUsgVOXqZOWChn8cvllZtv+F28npiG0q8= =W8iS -----END PGP SIGNATURE----- --ntslk7urmefcbfjr--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20180702192120.bmrv74c4atutx26b>