Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 06 Oct 2014 09:00:17 +0200
From:      John Marino <freebsd.contact@marino.st>
To:        Andrej Zverev <az@freebsd.org>, John Marino <marino@freebsd.org>
Cc:        "svn-ports-head@freebsd.org" <svn-ports-head@freebsd.org>, "svn-ports-all@freebsd.org" <svn-ports-all@freebsd.org>, Bartek Rutkowski <robak@freebsd.org>, "ports-committers@freebsd.org" <ports-committers@freebsd.org>
Subject:   Re: svn commit: r370131 - in head/net-mgmt: . nagios-check_dhcp.pl
Message-ID:  <54323E01.4080109@marino.st>
In-Reply-To: <CAD5bB%2BgVvAL1vaiBi7fmWQr_mtP-OAg__8h7O3=hPO4dJLxZbQ@mail.gmail.com>
References:  <201410052140.s95LeUa9030114@svn.freebsd.org>	<CAD5bB%2Bg5oUuWUXLpJia7vssd0SjTwn%2B0geRZApPULtQn%2B_gDxQ@mail.gmail.com>	<54323187.7040603@marino.st> <CAD5bB%2BgVvAL1vaiBi7fmWQr_mtP-OAg__8h7O3=hPO4dJLxZbQ@mail.gmail.com>

next in thread | previous in thread | raw e-mail | index | archive | help
On 10/6/2014 08:34, Andrej Zverev wrote:
> Hello John,
> 
> I don't see why shebangfix can't handle space.
> _SHEBANG_REINPLACE_ARGS+=       -e
> "1s|^\#![[:space:]]*${${lang}_OLD_CMD}|\#!${${lang}_CMD}|"

Actually I only took the other person's word that it didn't work when he
responded to "why didn't you use shebangfix?".  I don't know if he was
mistaken or maybe shebangfix has been improved in the meantime.

> Even if it can't you can make some handwork to obey framework instead of
> making one more way of doing this :-)

i essentially agree with you.

> But anyway, what about LOCALBASE and shebangfix? I think they can be
> fixed. If you prefer I can provide patch. Please don't get my email as
> something bad, If something can be done better so why not.

I didn't take it as bad.
I didn't respond to LOCALBASE because I thought it was valid and I left
that to robak to answer.  Probably both LOCALBASE and SHEBANGFIX should
be tweaked IMO.

John




Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?54323E01.4080109>