Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 31 Dec 2018 14:14:57 +0100
From:      Jan Beich <jbeich@FreeBSD.org>
To:        Rene Ladan <rene@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r488774 - head/graphics/gnash
Message-ID:  <k1jp-4z3i-wny@FreeBSD.org>
In-Reply-To: <y385-4z9q-wny@FreeBSD.org> (Jan Beich's message of "Mon, 31 Dec 2018 14:11:13 %2B0100")
References:  <201812311250.wBVCom6A020495@repo.freebsd.org> <y385-4z9q-wny@FreeBSD.org>

next in thread | previous in thread | raw e-mail | index | archive | help
Jan Beich <jbeich@FreeBSD.org> writes:

> Rene Ladan <rene@FreeBSD.org> writes:
>
>> Author: rene
>> Date: Mon Dec 31 12:50:48 2018
>> New Revision: 488774
>> URL: https://svnweb.freebsd.org/changeset/ports/488774
>>
>> Log:
>>   graphics/gnash: remove optional dependency on expired KDE4
> [...]
>> -OPTIONS_DEFINE=	CYGNAL VAAPI DOCS NLS
>> -OPTIONS_SINGLE=	MEDIA GUI RENDERER
>> +OPTIONS_DEFINE=	CYGNAL VAAPI DOCS NLS GTK2
>> +OPTIONS_SINGLE=	MEDIA RENDERER
>>  OPTIONS_SINGLE_MEDIA=	FFMPEG GSTREAMER
>> -OPTIONS_SINGLE_GUI=	GTK2 KDE4
>
> SINGLE means 1 option must be selected. If KDE4 is gone then GTK2 cannot
> be disabled. As DEFINE now allows GTK2 to be disabled it leads to IGNORE.
> So, can you drop the cruft as well?
[...]

Also, don't forget to drop %%GTK2%% in pkg-plist unlike my patch. ;)



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?k1jp-4z3i-wny>