Skip site navigation (1)Skip section navigation (2)
Date:      Mon, 13 Jan 2014 06:58:05 +0000
From:      Alexey Dokuchaev <danfe@FreeBSD.org>
To:        Diane Bruce <db@FreeBSD.org>
Cc:        svn-ports-head@freebsd.org, svn-ports-all@freebsd.org, ports-committers@freebsd.org
Subject:   Re: svn commit: r338054 - head/comms/yagiuda
Message-ID:  <20140113065805.GA92594@FreeBSD.org>
In-Reply-To: <201312300008.rBU08FP7035920@svn.freebsd.org>
References:  <201312300008.rBU08FP7035920@svn.freebsd.org>

next in thread | previous in thread | raw e-mail | index | archive | help
On Mon, Dec 30, 2013 at 12:08:15AM +0000, Diane Bruce wrote:
> New Revision: 338054
> URL: http://svnweb.freebsd.org/changeset/ports/338054
> 
> Log:
>   - Fix under stage
>   - add LICENSE

And also: "- Bogusly mute installation commands against established FreeBSD
practices and common sense". :(

> -	${INSTALL_PROGRAM} ${WRKSRC}/src/${f} ${PREFIX}/bin
> -	${INSTALL_MAN} ${WRKSRC}/man/man1/${f}.1 ${PREFIX}/man/man1
> +	@${INSTALL_PROGRAM} ${WRKSRC}/src/${f} ${STAGEDIR}${PREFIX}/bin
> +	@${INSTALL_MAN} ${WRKSRC}/man/man1/${f}.1 ${STAGEDIR}${PREFIX}/man/man1
>  .endfor
>  .for f in first optimise yagi input output
> -	${INSTALL_MAN} ${WRKSRC}/man/man5/${f}.5 ${PREFIX}/man/man5
> +	@${INSTALL_MAN} ${WRKSRC}/man/man5/${f}.5 ${STAGEDIR}${PREFIX}/man/man5
>  .endfor
> -.if !defined(NOPORTDOCS)
> -	${MKDIR} ${DOCSDIR}
> +	@${MKDIR} ${STAGEDIR}${DOCSDIR}
>  .for f in dipole.1.html input.1.html pattern.jpg\
>  	first.1.html optimise.1.html yagi.1.html\
>  	index.html output.1.html yagi.jpg
> -	${INSTALL_DATA} ${WRKSRC}/doc/$f ${DOCSDIR}
> +	@${INSTALL_DATA} ${WRKSRC}/doc/$f ${STAGEDIR}${DOCSDIR}

Needless to say, this is very wrong.

./danfe



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20140113065805.GA92594>