Date: Thu, 29 Sep 2016 20:05:58 -0700 From: Oleksandr Tymoshenko <gonzo@freebsd.org> To: John Baldwin <jhb@freebsd.org> Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r306355 - in head/sys: dev/atkbdc sys Message-ID: <96A0937C-C028-4F8F-B209-735F3DBF4338@freebsd.org> In-Reply-To: <3815150.rnkVxtqPiv@ralph.baldwin.cx> References: <201609262206.u8QM6J5q070986@repo.freebsd.org> <3815150.rnkVxtqPiv@ralph.baldwin.cx>
next in thread | previous in thread | raw e-mail | index | archive | help
> On Sep 27, 2016, at 1:55 PM, John Baldwin <jhb@freebsd.org> wrote: >=20 > On Monday, September 26, 2016 10:06:19 PM Oleksandr Tymoshenko wrote: >> Author: gonzo >> Date: Mon Sep 26 22:06:19 2016 >> New Revision: 306355 >> URL: https://svnweb.freebsd.org/changeset/base/306355 >>=20 >> Log: >> Add Elantech trackpad support >>=20 >> Elantech trackpads are found in some laptops like the Asus UX31E. = They >> are "synaptics compatible" but use a slightly different protocol. >>=20 >> Elantech hardware support is not enabled by default and just like >> Synaptic or TrackPoint devices it should be enabled by setting >> tunable, in this case hw.psm.elantech_support, to non-zero value >>=20 >> PR: 205690 >> Submitted by: Vladimir Kondratyev <wulf@cicgroup.ru> >> MFC after: 1 week >>=20 >> Modified: head/sys/dev/atkbdc/psm.c >> = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D >> --- head/sys/dev/atkbdc/psm.c Mon Sep 26 20:26:19 2016 = (r306354) >> +++ head/sys/dev/atkbdc/psm.c Mon Sep 26 22:06:19 2016 = (r306355) >> @@ -389,6 +465,9 @@ TUNABLE_INT("hw.psm.synaptics_support",=20 >> static int trackpoint_support =3D 0; >> TUNABLE_INT("hw.psm.trackpoint_support", &trackpoint_support); >>=20 >> +static int elantech_support =3D 0; >> +TUNABLE_INT("hw.psm.elantech_support", &elantech_support); >> + >> static int verbose =3D PSM_DEBUG; >> TUNABLE_INT("debug.psm.loglevel", &verbose); >=20 > It would be good to expose all these tunables as CTLFLAG_RDTUN = sysctls. Exposing > them that way with a decent description string makes it easier for = users to > discover tunables. Thanks for suggestion, John. Committed in r306474 =E2=80=94=20 gonzo=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?96A0937C-C028-4F8F-B209-735F3DBF4338>