Date: Mon, 17 Feb 2003 22:02:08 -0800 From: Marcel Moolenaar <marcel@xcllnt.net> To: Tim Robbins <tjr@FreeBSD.org> Cc: src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/bin/sh machdep.h memalloc.c nodes.c.pat Message-ID: <20030218060208.GC1973@athlon.pn.xcllnt.net> In-Reply-To: <20030218143222.A21049@dilbert.robbins.dropbear.id.au> References: <200302180208.h1I28Kbu046465@repoman.freebsd.org> <20030218022850.GB1973@athlon.pn.xcllnt.net> <20030218143222.A21049@dilbert.robbins.dropbear.id.au>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 18, 2003 at 02:32:22PM +1100, Tim Robbins wrote: > > > > Hmmm.... Maybe this is what's breaking ia64 as well. I just bumped > > _ALIGNBYTES from 7 to 15 and the argument passing seems to be > > screwed. Is that that what you see as well? > > Not quite, the "\320" chars from malloc()'s J flag were being appearing > in places. On panther: > install-info --quiet --defsection="Gcc Documentation" --defentry="* cppinternals: (cppinternals). The GNU compiler preprocessor internal documentation." cppinternals.info /usr/share/info/dir > install-info: excess command line argument `/usr/share/info/dir' > install-info: No such file or directory for ???????????????? > *** Error code 1 Got the same error. This is from installworld right? > I think the problem could have been that the initial stack block > in memalloc.c wasn't being aligned correctly, which I overlooked > when adding the alignment stuff to stalloc(): > > char *stacknxt = stackbase.space; > int stacknleft = MINSIZE; > > Try this (ugly) patch: http://people.freebsd.org/~tjr/align.diff I've not tried it yet, but I don't think you guarantee alignment here: -struct stack_block stackbase; +struct { + char _align[ALIGNBYTES + 1]; + struct stack_block _stackbase; +} sbalign; +#define stackbase sbalign._stackbase I'll first rebuild sh(1) so that my ia64 box is usable again and I'll play with it some more (starting with your patch). -- Marcel Moolenaar USPA: A-39004 marcel@xcllnt.net To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20030218060208.GC1973>