Date: Sun, 16 Apr 1995 06:38:42 -0700 From: Atsushi Murai <amurai> To: CVS-commiters, cvs-usrsbin Subject: cvs commit: src/usr.sbin/ppp command.c modem.c Message-ID: <199504161338.GAA00363@freefall.cdrom.com>
next in thread | raw e-mail | index | archive | help
amurai 95/04/16 06:38:41 Modified: usr.sbin/ppp command.c modem.c Log: Fixing follows and John's fruent explnation than my English.... The first problem I found was that descriptor 0 was being closed. This happens because the modem variable is set to 0 to indicate that it is not valid but there are not enough tests for the modem variable being 0. You can see where I have done this in the patch. Code in OpenModem() dups the modem descriptor if it is < 3. Once this happened the modem was always open and an incomming call would have getty and ppp reading the modem. Descriptor 1 is closed when the quit command was executed from a telnet connection. The next modem open returns descriptor 1 and this gets duped leaving the modem always open again. The modem was not being closed when the connection dropped or was closed from the other end. The UUCP lock was also not removed if the modem could not be opened. Reviewed by: Atsushi Murai <amurai@spec.co.jp> Submitted by: John Capo <jc@irbs.com>
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199504161338.GAA00363>