Date: Wed, 15 Jan 2020 13:32:07 +0100 (CET) From: Ronald Klop <ronald-lists@klop.ws> To: Baptiste Daroussin <bapt@FreeBSD.org> Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, Ian Lepore <ian@freebsd.org>, src-committers@freebsd.org Subject: Re: svn commit: r356725 - head/usr.bin/diff Message-ID: <927666564.6.1579091527217@localhost> In-Reply-To: <20200114171010.zdxpwpawn7mogaqy@ivaldir.net> References: <202001140822.00E8MS1b024516@repo.freebsd.org> <24cb346dd9f6de0f094dfa15c592d211e0d8f4a1.camel@freebsd.org> <20200114171010.zdxpwpawn7mogaqy@ivaldir.net>
next in thread | previous in thread | raw e-mail | index | archive | help
Van: Baptiste Daroussin <bapt@FreeBSD.org> Datum: dinsdag, 14 januari 2020 18:10 Aan: Ian Lepore <ian@freebsd.org> CC: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Onderwerp: Re: svn commit: r356725 - head/usr.bin/diff > > On Tue, Jan 14, 2020 at 08:44:29AM -0700, Ian Lepore wrote: > > On Tue, 2020-01-14 at 08:22 +0000, Baptiste Daroussin wrote: > > > Author: bapt > > > Date: Tue Jan 14 08:22:28 2020 > > > New Revision: 356725 > > > URL: https://svnweb.freebsd.org/changeset/base/356725 > > > > > > Log: > > > When system calls indicate an error they return -1, not some > > > arbitrary > > > value < 0. errno is only updated in this case. > > > > > > > What's the point of these changes, other than almost certainly leading > > to worse code generation? > > > > In most instruction sets, you can test for a value < 0 without using > > any instructions, you only need to examine the condition flags after > > loading the value. To compare equal to -1 typically requires at least > > 1 extra instruction, and on risc architectures typically at least two > > extra (load -1 to a register then compare). > > > our diff has forked from the OpenBSD one. The goal of those patches is to keep > in sync code that is still close to the original OpenBSD one as much as > possible. > > Best regards, > Bapt This is a nice example that it is valuable to describe in the commit message *why* a commit is made. Or "the goal" of the patches. Regards, Ronald. From owner-svn-src-all@freebsd.org Wed Jan 15 13:52:14 2020 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 5B9EE1F44D3; Wed, 15 Jan 2020 13:52:14 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "Let's Encrypt Authority X3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 47yTKB1lZYz4WjT; Wed, 15 Jan 2020 13:52:14 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org (repo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:0]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 3754F7849; Wed, 15 Jan 2020 13:52:14 +0000 (UTC) (envelope-from emaste@FreeBSD.org) Received: from repo.freebsd.org ([127.0.1.37]) by repo.freebsd.org (8.15.2/8.15.2) with ESMTP id 00FDqDsH092175; Wed, 15 Jan 2020 13:52:13 GMT (envelope-from emaste@FreeBSD.org) Received: (from emaste@localhost) by repo.freebsd.org (8.15.2/8.15.2/Submit) id 00FDqD7f092173; Wed, 15 Jan 2020 13:52:13 GMT (envelope-from emaste@FreeBSD.org) Message-Id: <202001151352.00FDqD7f092173@repo.freebsd.org> X-Authentication-Warning: repo.freebsd.org: emaste set sender to emaste@FreeBSD.org using -f From: Ed Maste <emaste@FreeBSD.org> Date: Wed, 15 Jan 2020 13:52:13 +0000 (UTC) To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r356759 - head/tools/build/options X-SVN-Group: head X-SVN-Commit-Author: emaste X-SVN-Commit-Paths: head/tools/build/options X-SVN-Commit-Revision: 356759 X-SVN-Commit-Repository: base MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/>; List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 15 Jan 2020 13:52:14 -0000 Author: emaste Date: Wed Jan 15 13:52:13 2020 New Revision: 356759 URL: https://svnweb.freebsd.org/changeset/base/356759 Log: Update WITHOUT_BINUTILS* descriptions In the WITHOUT_ descriptions we don't need to mention that ld.bfd is limited to powerpc. When WITHOUT_BINUTILS is specified ld.bfd is not installed on any CPU architecture. Modified: head/tools/build/options/WITHOUT_BINUTILS head/tools/build/options/WITHOUT_BINUTILS_BOOTSTRAP Modified: head/tools/build/options/WITHOUT_BINUTILS ============================================================================== --- head/tools/build/options/WITHOUT_BINUTILS Wed Jan 15 07:47:52 2020 (r356758) +++ head/tools/build/options/WITHOUT_BINUTILS Wed Jan 15 13:52:13 2020 (r356759) @@ -1,9 +1,8 @@ .\" $FreeBSD$ -Set to not build or install GNU +Do not build or install GNU .Xr as 1 , -.Xr objdump 1 , -and, on powerpc, -.Xr ld.bfd 1 +.Xr ld.bfd 1 , and +.Xr objdump 1 as part of the normal system build. The resulting system cannot build programs from source. Modified: head/tools/build/options/WITHOUT_BINUTILS_BOOTSTRAP ============================================================================== --- head/tools/build/options/WITHOUT_BINUTILS_BOOTSTRAP Wed Jan 15 07:47:52 2020 (r356758) +++ head/tools/build/options/WITHOUT_BINUTILS_BOOTSTRAP Wed Jan 15 13:52:13 2020 (r356759) @@ -1,5 +1,5 @@ .\" $FreeBSD$ -Set to not build binutils (as, objdump, and on powerpc ld) +Do not build binutils (as, ld.bfd, and objdump) as part of the bootstrap process. .Bf -symbolic The option does not work for build targets unless some alternative
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?927666564.6.1579091527217>