Date: Tue, 02 Jun 2009 14:12:31 +0200 From: Alexander Leidinger <Alexander@Leidinger.net> To: Doug Barton <dougb@FreeBSD.org> Cc: freebsd-current@FreeBSD.org, Andriy Gapon <avg@FreeBSD.org> Subject: Re: fsck_y_enable: use -C Message-ID: <20090602141231.67987dnz529yuqgw@webmail.leidinger.net> In-Reply-To: <4A240331.1000803@FreeBSD.org> References: <4A23D5A4.6020009@icyb.net.ua> <4A23F4B8.7000002@freebsd.org> <4A240331.1000803@FreeBSD.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Quoting Doug Barton <dougb@FreeBSD.org> (from Mon, 01 Jun 2009 =20 09:34:57 -0700): > Andriy Gapon wrote: >> on 01/06/2009 16:20 Andriy Gapon said the following: >>> What about the following patch? >>> I believe that the idea behind fsck_y_enable is to try to make =20 >>> unattended systems >>> with rw filesystems as recoverable as possible at the cost of =20 >>> potential damage to >>> the data. The new "-C" option should not interfere with this goal, =20 >>> but should >>> reduce recovery time, because currently fsck -y checks *all* =20 >>> filesystems from >>> fstab, even those that are ro or clean: >>> >>> -C Check if the =E2=80=9Cclean=E2=80=9D flag is set in the superblo= ck and skip file >>> system checks if file system was properly dismounted and marked >>> clean. >>> >> >> One potential issue that I've just thought of is that fsck_msdosfs =20 >> doesn't seem to >> support this option (even in a dummy way), so it would be a problem =20 >> for those who >> have msdos filesystems in fstab and also have fsck_y_enable. > > I'm a bit concerned that we keep the current option as it is, but I > would support adding an fsck_y_enable_flags option to allow people to > pass -C if they are sure it will work in their environment. What about _flags and also adding a NOP for -C in fsck_msdosfs? Bye, Alexander. --=20 Another dream that failed. There's nothing sadder. =09=09-- Kirk, "This side of Paradise", stardate 3417.3 http://www.Leidinger.net Alexander @ Leidinger.net: PGP ID =3D B0063FE7 http://www.FreeBSD.org netchild @ FreeBSD.org : PGP ID =3D 72077137
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20090602141231.67987dnz529yuqgw>