Date: Fri, 6 Apr 2007 12:35:19 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Andrey Chernov <ache@freebsd.org>, Bruce Evans <bde@zeta.org.au>, src-committers@FreeBSD.org, cvs-src@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/include stdio.h src/lib/libc/sys lseek.2 pathconf.2 src/sys/kern vfs_syscalls.c src/sys/sys filio.h unistd.h Message-ID: <20070406103519.GA1251@garage.freebsd.pl> In-Reply-To: <20070406053934.GA84722@nagual.pp.ru> References: <200704052110.l35LAsXH013966@repoman.freebsd.org> <20070406115326.A43678@delplex.bde.org> <20070406053934.GA84722@nagual.pp.ru>
next in thread | previous in thread | raw e-mail | index | archive | help
--M9NhX3UHpAaciwkO Content-Type: text/plain; charset=iso-8859-2 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Apr 06, 2007 at 09:39:35AM +0400, Andrey Chernov wrote: > On Fri, Apr 06, 2007 at 11:58:55AM +1000, Bruce Evans wrote: > > On Thu, 5 Apr 2007, Pawel Jakub Dawidek wrote: > >=20 > > >pjd 2007-04-05 21:10:54 UTC > > > > > > FreeBSD src repository > > > > > > Modified files: > > > include stdio.h > > > lib/libc/sys lseek.2 pathconf.2 > > > sys/kern vfs_syscalls.c > > > sys/sys filio.h unistd.h > > > Log: > > > Implement SEEK_DATA and SEEK_HOLE extensions to lseek(2) as found in > > > OpenSolaris. For more information please refer to: > > > > > > http://blogs.sun.com/bonwick/entry/seek_hole_and_seek_data > >=20 > > These are just namespace pollution in stdio.h. stdio (fseek()) doesn't > > support them, and the hack of declaring lseek() in stdio.h should not > > be extended to new interfaces. If stdio ever supports them, then they > > would need to be declared under a visibility ifdef (not #ifdef self). >=20 > I agree. They must be implemented in fseek.c code first before adding the= m=20 > to stdio.h and ifdefed with proper *_VISIBLE tags in all places. > Perhaps new __CDDL_VISIBLE tag required for it. This is not CDDL licensed. I'm planning to implement support for SEEK_DATA and SEEK_HOLE for UFS. --=20 Pawel Jakub Dawidek http://www.wheel.pl pjd@FreeBSD.org http://www.FreeBSD.org FreeBSD committer Am I Evil? Yes, I Am! --M9NhX3UHpAaciwkO Content-Type: application/pgp-signature Content-Disposition: inline -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (FreeBSD) iD8DBQFGFiJnForvXbEpPzQRAq71AKC/HrqZwR6/dYAKPzcnC5TFmDqw5ACfap5b 9k2vFRXcGraX9ZiQ0tNCclE= =cxgH -----END PGP SIGNATURE----- --M9NhX3UHpAaciwkO--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20070406103519.GA1251>