Skip site navigation (1)Skip section navigation (2)
Date:      Sun, 28 Mar 2010 12:38:08 +0200 (CEST)
From:      Christoph Moench-Tegeder <cmt@burggraben.net>
To:        FreeBSD-gnats-submit@FreeBSD.org
Subject:   ports/145104: [PATCH] unbreak x11/xloadimage (fallout from libpng upgrade)
Message-ID:  <20100328103808.A5E8DAC827@elch.exwg.net>
Resent-Message-ID: <201003281040.o2SAe2Eb032512@freefall.freebsd.org>

next in thread | raw e-mail | index | archive | help

>Number:         145104
>Category:       ports
>Synopsis:       [PATCH] unbreak x11/xloadimage (fallout from libpng upgrade)
>Confidential:   no
>Severity:       serious
>Priority:       medium
>Responsible:    freebsd-ports-bugs
>State:          open
>Quarter:        
>Keywords:       
>Date-Required:
>Class:          sw-bug
>Submitter-Id:   current-users
>Arrival-Date:   Sun Mar 28 10:40:02 UTC 2010
>Closed-Date:
>Last-Modified:
>Originator:     Christoph Moench-Tegeder
>Release:        FreeBSD 8.0-RELEASE-p2 amd64
>Organization:
>Environment:
System: FreeBSD elch.exwg.net 8.0-RELEASE-p2 FreeBSD 8.0-RELEASE-p2 #8: Sat Feb 20 21:36:50 CET 2010 cmt@elch.exwg.net:/usr/obj/usr/src/sys/CMT amd64

	png-1.4.1
	xloadimage-4.1.16_6 (upgrading to xloadimage-4.1.16_7)

>Description:
	Function png_set_gray_1_2_4_to_8() from libpng was renamed to
	png_set_expand_gray_1_2_4_to_8() (according to the libpng CHANGES file),
	so xloadimage bails out with a linker error.
>How-To-Repeat:
	run portupgrade
>Fix:

	Change xloadimage.4.1/png.c with REINPLACE_CMD (very simple):
	(also available at http://burggraben.net/hacks/xloadimage.patch )


--- x11/xloadimage/Makefile.orig	2010-03-28 12:28:30.000000000 +0200
+++ x11/xloadimage/Makefile	2010-03-28 12:27:22.000000000 +0200
@@ -39,6 +39,8 @@
 
 post-patch:
 	@${CHMOD} a+rx ${WRKSRC}/configure
+	@${REINPLACE_CMD} -e 's|png_set_gray_1_2_4_to_8|png_set_expand_gray_1_2_4_to_8|' \
+		${WRKSRC}/png.c
 	@cd ${WRKSRC}; ${MV} xloadimage.man xloadimage.man.old; \
 		${SED} -e s:/etc/X11/Xloadimage:${PREFIX}/etc/xloadimagerc: \
 		       -e s:/usr/lib/xloadimagerc:${PREFIX}/etc/xloadimagerc: \
	


>Release-Note:
>Audit-Trail:
>Unformatted:



Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20100328103808.A5E8DAC827>