Date: Thu, 04 Jan 2001 23:43:19 +0000 From: Paul Richards <paul@originative.co.uk> To: Tony Finch <dot@dotat.at> Cc: Paul Richards <paul@freebsd-services.co.uk>, Dag-Erling Smorgrav <des@ofug.org>, Mark Murray <mark@grondar.za>, Paul Richards <paul@FreeBSD.org>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.sbin/pkg_install/update pkg_update.pl Message-ID: <3A550A97.C7789A6C@originative.co.uk> References: <xzp8zorla59.fsf@flood.ping.uio.no> <200101041509.f04F9kY06526@gratis.grondar.za> <xzp3dezl2gm.fsf@flood.ping.uio.no> <3A54A329.3A84087F@freebsd-services.co.uk> <20010104214946.W2140@hand.dotat.at> <3A54F477.DCD11D4B@originative.co.uk> <20010104224743.Z2140@hand.dotat.at>
next in thread | previous in thread | raw e-mail | index | archive | help
Tony Finch wrote: > > Paul Richards <paul@originative.co.uk> wrote: > > > >The mistake was using "<$file", what I should have done was use the list > >version i.e. > > > >open(HANDLE, "<", $file) > > That must require perl 5.6 because it doesn't work in 5.005. Yes it does, maybe not such a generic solution then but probably the correct way to code things in the future. In any case, this thread is a bit of a red herring, the fix I applied of "< $file" is a correct fix for the bug though it is not as safe as it could be since $file does need some taint checking. Paul. To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?3A550A97.C7789A6C>