Date: Thu, 05 Jul 2007 17:18:43 +0300 From: Danny Braniss <danny@cs.huji.ac.il> To: Kostik Belousov <kostikbel@gmail.com> Cc: current@freebsd.org Subject: Re: HEADS UP: destroy_dev_sched() KPI in the tree Message-ID: <E1I6SAN-0000by-Bt@cs1.cs.huji.ac.il> In-Reply-To: <20070703180141.GJ2200@deviant.kiev.zoral.com.ua> References: <20070703180141.GJ2200@deviant.kiev.zoral.com.ua>
next in thread | previous in thread | raw e-mail | index | archive | help
> Today, I got re@ permission and committed the destroy_dev_sched() KPI > into the tree. As suggested by Nate Lawson, destroy_dev() tries to > auto-detect "devdrn" deadlock condition and transforms destroy_dev() > from d_close() csw method into destroy_dev_sched(). I together with > Peter Holm tried to test the change as thoroughly as possible. > > The obvious problematic area are the races between device driver > module unload and destroy_dev_sched(). At least smb(4) definitely > has that race that shall be worked around by draining events with > drain_dev_clone_events() and destroy_dev_drain(&cdevsw); see snp(4) > change for example. > > Please, report issues caused by the patch to the list with me Cc:ed. > Change of autodetection of deadlock in destroy_dev() was made in separate > commit for ease of reverting. and today I got a chance to check it, and it works for me (iscsi_initiator). danny
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?E1I6SAN-0000by-Bt>