Date: Mon, 30 Oct 2017 20:54:33 -0700 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Mariusz Zaborski <oshogbo@FreeBSD.org> Cc: src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r325062 - in head/lib: . libcasper libcasper/libcasper libcasper/services libcasper/services/cap_dns libcasper/services/cap_dns/tests libcasper/services/cap_grp libcasper/services/cap_g... Message-ID: <D0C4499A-B2A6-4BB2-8A57-A37BF73D9438@gmail.com> In-Reply-To: <201710281923.v9SJNvE5021346@repo.freebsd.org> References: <201710281923.v9SJNvE5021346@repo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_774282D6-59C0-4AF4-8B5E-8E2F46DA909F Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > On Oct 28, 2017, at 12:23, Mariusz Zaborski <oshogbo@FreeBSD.org> = wrote: >=20 > Author: oshogbo > Date: Sat Oct 28 19:23:57 2017 > New Revision: 325062 > URL: https://svnweb.freebsd.org/changeset/base/325062 >=20 > Log: > Introduce caspermocks. >=20 > The idea behinds mocks is that we don't need to ifdef a lot of code = in > tools itself but those defines are hidden in the casper library. > Right now the mocks are implemented as define/inlines functions. > There was a very long discussion how this should be implemented. > This approach has some advantages like we don't need to link to any = additional > libraries. Unfortunately there are also some disadvantages for = example it is > easy to get library out of sync between two versions of functions or = that we > need extra define to compile program with casper support. > This isn't an ideal solution but it's good enough for now and should = simplify > capsicumizing programs. This also doesn't close us any other ways to = do those > mocks and this should evolve in time. >=20 > Discussed with: pjd, emaste, ed, rwatson, bapt, cem, bdrewery > Differential Revision: https://reviews.freebsd.org/D8753 This change broke tinderbox/Jenkins for powerpc and sparc64: = https://ci.freebsd.org/job/FreeBSD-head-powerpc-build/1865/console . -Ngie --Apple-Mail=_774282D6-59C0-4AF4-8B5E-8E2F46DA909F Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEE5bk3FaGcY5rvqmb79YOpJmkwhhUFAln38/kACgkQ9YOpJmkw hhWHtBAAjhWrS+O8inpXwa0pBsQZPJocfW8uWIb9IRs9wCd9mOwxdc3vTpelmr2U N9/7q96KmeebQxIwBOCyzB7GyXHniVmmO96mhCTtMC1SBvUpJOc67mbklG94GfJ2 BKJmvb6WcGz/tjvgc+OiUcl1MKzcRjX7cenzv24TGylRJ9Ej0p2KrpXB4s4rRb3R MS0Z0ZjrXaYduiTy28qs8IwYamiSDdMkX9c7AbD0ItL/uJLZjpV4QOmFOh4CFY0Z pYAUwPY+zuOdzCN/6wplnAJrLWIAd7kb+MI2QREJVHYLFsZZ82xlOHSvHBStiEHa SqJXss5w6NkRFf1ev2sQVllXIu2OH2Mpvx0tpNLUOeSA3xfdaC2CPtm1KEzbHxCE Sy8gManeOQV3u1V2GorDn1wGDtngrT1YaYj2CBNmd5xDkkn/5jvzeosy3+lebU9R /plj8h1juW9jGpCsfOfmaS3kRGp8bhhGcBDOITCNlnMigjnyWm/0ewEVQWDSV4ZO t5g+8nFc8r1si3u8pV3d6vN5+jSOj3HaxyrEEQp49kY/Zz9ZTJ+so4ykWTEX8ogi RyCHje28aA33xkGb31vbax5gaaTLL76yxVmhSK6xPtNu226Q6t/ZDUzCBhx4rj3+ 5Pf7Upjxy/juJENTpnyEiDjkNWOgG3sIFaibW6HYLZ6EWUlUIzU= =EiDE -----END PGP SIGNATURE----- --Apple-Mail=_774282D6-59C0-4AF4-8B5E-8E2F46DA909F--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?D0C4499A-B2A6-4BB2-8A57-A37BF73D9438>