Date: Fri, 8 Sep 2006 13:08:35 +1200 From: Andrew Thompson <thompsa@freebsd.org> To: Andre Oppermann <andre@freebsd.org> Cc: freebsd-net@freebsd.org, yar@comp.chem.msu.su, freebsd-arch@freebsd.org Subject: Re: Moving ethernet VLAN tags into the mbuf packet header (from mtags) Message-ID: <20060908010835.GA6334@heff.fud.org.nz> In-Reply-To: <450035AD.3040600@freebsd.org> References: <450035AD.3040600@freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
On Thu, Sep 07, 2006 at 05:07:25PM +0200, Andre Oppermann wrote: > With the recent addition of a 16bit field for TSO into the mbuf packet > header we've got 16bits left over. I've reserved these bits for the > ethernet VLAN tagging of packet to do away with the allocated mbuf mtag. > > The change is rather mechanical. Patch available here: > > http://people.freebsd.org/~andre/vlan_pkthdr-20060907.diff > RCS file: /home/ncvs/src/sys/netgraph/ng_vlan.c,v retrieving revision 1.3 diff -u -p -r1.3 ng_vlan.c --- netgraph/ng_vlan.c 20 Apr 2005 14:19:20 -0000 1.3 +++ netgraph/ng_vlan.c 7 Sep 2006 15:03:58 -0000 <...> - vlan = EVL_VLANOFTAG(VLAN_TAG_VALUE(mtag)); + vlan = m->m_pkthdr.ether_vlan; (void)&evl; /* XXX silence GCC */ I think this is a typeo, EVL_VLANOFTAG is still needed. I like the change and it helps out a few related projects that people are working on. Andrew
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20060908010835.GA6334>