Date: Wed, 4 Aug 2021 08:29:34 -0600 From: Warner Losh <imp@bsdimp.com> To: "Rodney W. Grimes" <rgrimes@freebsd.org> Cc: Baptiste Daroussin <bapt@freebsd.org>, src-committers <src-committers@freebsd.org>, "<dev-commits-src-all@freebsd.org>" <dev-commits-src-all@freebsd.org>, dev-commits-src-main@freebsd.org Subject: Re: git: 184d64af1344 - main - locales: stop hardcoding the directories in the mtree Message-ID: <CANCZdfpca9EcX66u=4EmeFD6K6XgD9O38jHs6Bi0hF4T8LyJbQ@mail.gmail.com> In-Reply-To: <202108041344.174DiVr0052682@gndrsh.dnsmgr.net> References: <1acb127e-1d2c-4c9f-96e6-23bfbf9695ac@FreeBSD.org> <202108041344.174DiVr0052682@gndrsh.dnsmgr.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Wed, Aug 4, 2021 at 7:44 AM Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net> wrote: > > 3 ao?t 2021 19:32:44 Rodney W. Grimes <freebsd@gndrsh.dnsmgr.net>: > > > > >> The branch main has been updated by bapt: > > >> > > >> URL: > https://cgit.FreeBSD.org/src/commit/?id=184d64af1344d6f3c370499510cede49320f4863 > > >> > > >> commit 184d64af1344d6f3c370499510cede49320f4863 > > >> Author:???? Baptiste Daroussin <bapt@FreeBSD.org> > > >> AuthorDate: 2021-08-03 12:25:00 +0000 > > >> Commit:???? Baptiste Daroussin <bapt@FreeBSD.org> > > >> CommitDate: 2021-08-03 12:25:00 +0000 > > >> > > >> ??? locales: stop hardcoding the directories in the mtree > > >> ??? > > >> ??? The framework knows how to create directories and tag them > properly > > >> ??? for a the creation of a mtree, not need to hardcode all the > locales > > >> ??? entries in bsd.usr.mk > > >> ??? > > >> ??? This simplifies addition of new locales but also allow people > building > > >> ??? with WITHOUT_LOCALES to end up with a directory full of empty > files > > > > > > The uses of /etc/mtree go beyond the simple directory creation, > > > please cause something to build a BSD.locale.dist file and install > > > it in /etc/mtree to replace the functionality removal you have > > > just performed. > > > > > > Thanks, > > > Rod > > > > > > > Please provide a valid use case not working anymore after this change > and I will consider. > > From mtree(1): > The mtree utility compares a file hierarchy against a > specification, > > Since the shipped specification is now incomplete it can no longer be used > to do validate the hiararchy of a system against RELEASED /etc/mtree files. > install -d broke this at least a decade or more ago. Most people really don't care outside of things in /var getting created since validating directories is of such little functionality w/o also validating binaries and such. It's used in bsd.files.mk which is included by lots of things in the tree. > Note that this is not the only part of the tree where the same thing is > done. > > More regression does not make regression right. > The decision was made a long time ago to leave this feature behind, though you can still get it today if you do a NO_ROOT build because that creates a metafile that includes both directories and files for the system. pkg base uses that to generate its packages. NO_ROOT builds are better anyway, because it also lets you tag each file / directory on a per-package basis so you don't have them if you don't install a specific package. Warner > > Best, > > Bapt > -- > Rod Grimes > rgrimes@freebsd.org >
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CANCZdfpca9EcX66u=4EmeFD6K6XgD9O38jHs6Bi0hF4T8LyJbQ>