Date: Sat, 19 Aug 2000 10:26:27 -0700 From: Marcel Moolenaar <marcel@cup.hp.com> To: Brian Fundakowski Feldman <green@FreeBSD.org> Cc: "Andrey A. Chernov" <ache@nagual.pp.ru>, cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/usr.bin/make Makefile config.h job.c main.c Message-ID: <399EC343.75A93A8@cup.hp.com> References: <Pine.BSF.4.21.0008170036230.97352-100000@green.dyndns.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Brian Fundakowski Feldman wrote:
>
> On Thu, 17 Aug 2000, Andrey A. Chernov wrote:
>
> > On Wed, Aug 16, 2000 at 04:31:44PM -0700, Brian Feldman wrote:
> > > green 2000/08/16 16:31:44 PDT
> > >
> > > Modified files:
> > > usr.bin/make Makefile config.h job.c main.c
> > > Log:
> > > Allow use of the ${MAKE_SHELL} variable to specify alternate shells for
> > > make(1) to use. Setting it to "sh" and "ksh" are the only values which
> > > work right ATM; I wouldn't expect "csh" to get you far ;)
> >
> > There always was ${SHELL} variable for it present in 'make', isn't ?
>
> To be honest, it really doesn't work right. This does, however :) This
> is a very simple change, anyway; some shells require special handling
> to set up, etc. If you want to make ${SHELL} work better... =)
I can't say I like the change. We use MAKE_SHELL={"csh", "sh", "ksh"} in
Makefile. This translates to DEFSHELL={0,1,2} in the sources, which is
ugly. At the same time we need to support the runtime ".SHELL". Looking
at the code now, I still see hardcoded shell names and hardcoded
special-handling based on build-time conditions instead of run-time
conditions.
Using MAKE_SHELL: csh doesn't seem to work and we don't have ksh in the
source tree. This basicly leaves only sh for us as a meaningful default.
I can't say we have a pressing need to have this functionality in the
first place.
I think that instead of fixing any problems, we introduced more. I'd
prefer this is backed out and work is started on real fixes. Anyone that
has ksh installed and want to use it can then use .SHELL. We can even
make that make.conf controlled, if people want it...
--
Marcel Moolenaar
mail: marcel@cup.hp.com / marcel@FreeBSD.org
tel: (408) 447-4222
To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe cvs-all" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?399EC343.75A93A8>