Date: Mon, 18 Jun 2012 16:27:49 -0700
From: Jason Helfman <jgh@FreeBSD.org>
To: FreeBSD-gnats-submit@FreeBSD.org
Cc: admin@lissyara.su
Subject: ports/169216: [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
Message-ID: <1340062069.466114.56284.nullmailer@experts-exchange.com>
Resent-Message-ID: <201206182330.q5INUJdj015299@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 169216
>Category: ports
>Synopsis: [PATCH] net/skystar2: fix usage of ${SRC_BASE} before it is defined
>Confidential: no
>Severity: non-critical
>Priority: low
>Responsible: freebsd-ports-bugs
>State: open
>Quarter:
>Keywords:
>Date-Required:
>Class: change-request
>Submitter-Id: current-users
>Arrival-Date: Mon Jun 18 23:30:19 UTC 2012
>Closed-Date:
>Last-Modified:
>Originator: Jason Helfman
>Release: FreeBSD 8.3-RELEASE amd64
>Organization:
>Environment:
System: FreeBSD dormouse.experts-exchange.com 8.3-RELEASE FreeBSD 8.3-RELEASE #0: Mon Apr 9 21:23:18 UTC
>Description:
Original PR filed as ports/165994
SRC_BASE is being used before being defined in several ports. it happened to
work anyways in most cases because the main use of SRC_BASE is for checking if
${SRC_BASE}/sys/ (/usr/src/sys/) exists, and if SRC_BASE is empty, it just
checks for /sys/ which does exist on most systems as a symlink to /usr/src/sys/.
pet portlint on pkg-message and placement of USE_BZIP2
Port maintainer (admin@lissyara.su) is cc'd.
Generated with FreeBSD Port Tools 0.99_6 (mode: change, diff: CVS)
>How-To-Repeat:
>Fix:
--- skystar2-1.32,1.patch begins here ---
Index: Makefile
===================================================================
RCS file: /home/pcvs/ports/net/skystar2/Makefile,v
retrieving revision 1.12
diff -u -r1.12 Makefile
--- Makefile 1 Apr 2010 05:27:58 -0000 1.12
+++ Makefile 18 Jun 2012 23:28:21 -0000
@@ -17,6 +17,9 @@
COMMENT= Kernel module and program for SkyStar2/SkyStar2.8A, ver. ${PORTVERSION}
USE_BZIP2= yes
+
+.include <bsd.port.pre.mk>
+
SYSDIR?= ${SRC_BASE}/sys
KMODDIR= /boot/modules
PLIST_SUB+= KMODDIR=${KMODDIR}
@@ -49,8 +52,6 @@
.endfor
.endif
-.include <bsd.port.pre.mk>
-
.if ${ARCH} == "ia64" || ${ARCH} == "powerpc" || ${ARCH} == "sparc64"
BROKEN= Does not compile on ia64, powerprc, or sparc64
.elif ${OSVERSION} >= 900000
Index: pkg-message
===================================================================
RCS file: /home/pcvs/ports/net/skystar2/pkg-message,v
retrieving revision 1.2
diff -u -r1.2 pkg-message
--- pkg-message 3 Jun 2008 18:12:12 -0000 1.2
+++ pkg-message 18 Jun 2012 23:28:21 -0000
@@ -11,5 +11,3 @@
to your /boot/loader.conf.
*********************************************************************
-
-
--- skystar2-1.32,1.patch ends here ---
>Release-Note:
>Audit-Trail:
>Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?1340062069.466114.56284.nullmailer>