Date: Tue, 19 Feb 2019 02:50:15 +0900 From: Li-Wen Hsu <lwhsu@freebsd.org> To: Greg Veldman <greg@gregv.net> Cc: freebsd-office@freebsd.org, Greg V <greg@unrelenting.technology>, Greg Veldman <freebsd@gregv.net>, Jung-uk Kim <jkim@freebsd.org>, Justin Hibbits <jhibbits@freebsd.org> Subject: Re: [call for help] libreoffice 6.2 update Message-ID: <CAKBkRUztkbJJTHe2B24MmCpcVeeR83%2Bi9Y6pUUhDO-P8bgOomw@mail.gmail.com> In-Reply-To: <20190218150917.GB98237@aurora.gregv.net> References: <CAKBkRUwohGA4Lka-tpCZnj7rt2V=henc%2B0b==HtLxP-WLXeLJg@mail.gmail.com> <CAKBkRUyeYa4V8op6FS-mPqUUMXgwQ3mLze0WFFf3z2Z-_KNiBw@mail.gmail.com> <CAKBkRUyD3hXOdfMdNfU78CPUYWOEJT3TfUTm3OW_9JDHhs=Ebw@mail.gmail.com> <20190218144218.GA98237@aurora.gregv.net> <20190218150917.GB98237@aurora.gregv.net>
next in thread | previous in thread | raw e-mail | index | archive | help
On Tue, Feb 19, 2019 at 12:09 AM Greg Veldman <greg@gregv.net> wrote: > > On Mon, Feb 18, 2019 at 09:42:18AM -0500, Greg Veldman wrote: > > On Tue, Feb 05, 2019 at 11:12:25AM +0800, Li-Wen Hsu wrote: > > > Again, LibreOffice 6.2 will be announced soon. I squeezed few hours > > > to get most the patches updated > > > ( patch-bridges_source_cpp__uno_gcc3__linux__intel_share.hxx > > > and patch-bridges_source_cpp__uno_gcc3__linux__intel_uno2cpp.cxx > > > still need more work) > > > in my working repository: https://github.com/lwhsu/freebsd-ports-libreoffice > > > > I took a look at this, and now have all patches applying cleanly. > > However it appears some of these patches (or parts thereof) may > > actually no longer be needed, as upstream changed the arguments > > to some of the functions. I'm trying to read/understand the > > back story on some of these patches from the various commit logs > > to be sure if it's safe to change them.. > > OK, so that was actually a lot easier than I thought. Looks > like the two patches in question were introduced in r395799 > to make LibreOffice build on systems with pre-C++-11 compilers > (specifically, FreeBSD 9.x). As 9.x hasn't been officially > supported in over two years and the base C++ on 11.2 uses > C++-14, can I suggest that we just drop these patches rather > than trying to carry them forward every time LibreOffice gets > updated? Thanks very much for the help! Dropping these patches and focusing on the supported FreeBSD versions sounds very reasonable to me. Li-Wen
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?CAKBkRUztkbJJTHe2B24MmCpcVeeR83%2Bi9Y6pUUhDO-P8bgOomw>