Date: Fri, 7 Jul 2006 04:41:59 GMT From: Javier Villavicencio <javier_v@ciudad.com.ar> To: freebsd-gnats-submit@FreeBSD.org Subject: misc/99870: INTRCNT_COUNT in i386/intr_machdep.h (may be) wrongly defined Message-ID: <200607070441.k674fxaY073367@www.freebsd.org> Resent-Message-ID: <200607070450.k674oEJA052823@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 99870 >Category: misc >Synopsis: INTRCNT_COUNT in i386/intr_machdep.h (may be) wrongly defined >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Fri Jul 07 04:50:14 GMT 2006 >Closed-Date: >Last-Modified: >Originator: Javier Villavicencio >Release: 6.1-RELEASE >Organization: >Environment: >Description: Web viewable at: http://www.freebsd.org/cgi/cvsweb.cgi/src/sys/i386/include/intr_machdep.h?rev=1.7.2.3&content-type=text/x-cvsweb-markup By my interpretation of the following comments before the definition: /* * - 1 ??? dummy counter. * - 2 counters for each I/O interrupt. * - 1 counter for each CPU for lapic timer. * - 7 counters for each CPU for IPI counters for SMP. */ #ifdef SMP #define INTRCNT_COUNT (1 + NUM_IO_INTS * 2 + 1) #else #define INTRCNT_COUNT (1 + NUM_IO_INTS * 2 + (1 + 7) * MAXCPU) #endif It seems that the #ifdef should be an #ifndef. >How-To-Repeat: Look at the code? The GENERIC kernel compiles and works fine, I've found this just looking for some "custom" environment (that's why no uname -a is provided) >Fix: -#ifdef SMP +#ifndef SMP >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?200607070441.k674fxaY073367>