Date: Wed, 20 Mar 2013 12:21:16 +0200 From: Konstantin Belousov <kostikbel@gmail.com> To: Doug Ambrisko <ambrisko@ambrisko.com> Cc: arch@freebsd.org, gleb@freebsd.org Subject: Re: Increase the mount path to MAXPATHLEN? Message-ID: <20130320102116.GA3794@kib.kiev.ua> In-Reply-To: <20130319201145.GA19260@ambrisko.com> References: <20130319201145.GA19260@ambrisko.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--FX1XXxwkuRo+XMsw Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Mar 19, 2013 at 01:11:45PM -0700, Doug Ambrisko wrote: > I have a patch at: > http://people.freebsd.org/~ambrisko/statf.patch > that people can glance at. If this approach is the right way to go > then I update it for the latest -current and update it. No, I do not think this is the right approach. You are breaking the ABI in the backward-incompatible way. What should be done is versioning the fstatfs(2) and other related symbols from libc. Please look at the lib/libc/include/compat.h and its use for upgrading the syscalls ABI. Also, the whole ABI of the system should be inspected for the changes, due to possible use of the struct statfs in other structures, or as an argument to other functions. Gleb Kurtsou (gleb@) has a tool which could compare a set of the shlibs before and after change for the ABI drift, using the dward debugging information. I do not remember where it is stored, definitely worth committing somewhere at tools/tools. --FX1XXxwkuRo+XMsw Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.19 (FreeBSD) iQIcBAEBAgAGBQJRSY2bAAoJEJDCuSvBvK1BM+kP/RZGfV+1z8FHYWx6EJ6Rolt+ EzE6IvsXcJNRVS81rWSCgWfVVfZImosqx66S7b7SdeWA1uJoyFtw4U4j8FUAvJlr /uR5P6xR2+lTcf16VhTZwFTzce8VsxNenmJKTZQJz+xGtE+F3ySRO6fkNAQo38Jn u8iW5+jgId/qrQDoRRnd8ljhAwTKwMC3u7fYzCPnUGnMCa5MKPFaiqrBObtun0GM uU3vene9hWQ3+r3enO2dWYuUbAC6V/KjiEvbpvHx1+aRP0yADIl5N58G08K2Hkse e6ddd2UlT11ydSfPGifZWip4qHUCLcVeH3ZkH4SW6ZEAkPLrqTlxtjOoH1ZOZW4D sNEtmsQXo7Yi6hVwFi/sLIstRJvMevIP1uZU2zgI0/nMBdbKQJOGxIa49vG8/Dic xH8WsYPUkhEp1LLWF+Pwp/BUOpfggcOq1/uccZ7VuSyTnBPpUavhb5orVeW+91Up nZezjijdPH85PADcrapE6hz7of2tN58I/JN/aOxHu2oRdQPx9BsRiUej+InT5fA5 TaHvApBpwa2aADDfmd+5e54r+bF+QyWruY2CkfE6ihr4qk0Ea9RZu4AiNuzvldTw wXQkJ1Gpps/QwmpzC5hxFPyi0UegrKXFFa1J4uiOnm0TQPbRd+1sZpa+I2uGTK8h 4EDsDUiAXr/JJ6Bt69cW =Y9Wy -----END PGP SIGNATURE----- --FX1XXxwkuRo+XMsw--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20130320102116.GA3794>